Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troute.network: handle fiona dependency for geopandas>=1.0.0 #827

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

program--
Copy link
Contributor

@program-- program-- commented Aug 14, 2024

This PR adds fiona to the troute.network dependencies to handle the case when consumers have geopandas>=1.0.0 without explicitly installing fiona. This change shouldn't impact consumers with geopandas<1.0.0, since fiona will already be installed.

Additions

  • Adds fiona to troute.network's pyproject.toml dependencies

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@shorvath-noaa shorvath-noaa merged commit bb7d6ec into NOAA-OWP:master Aug 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants