Update for usace issue

[AminTorabi-NOAA]

in the config file usace_timeslices_folder : usace_timeslices/ the letter 's' was missing and that was causing the t-rout skip usace_timeslices folder. By adding 's' it would go through the folder but since the usace files are all empty it throw an error and couldn't process it. So the update in nhd_io.py checks if the size is zero then return empty dataframe

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Windows
• Linux
• Browser

Accessibility

• Keyboard friendly
• Screen reader friendly

Other

• Is useable without CSS
• Is useable without JS
• Flexible from small to large screens
• No linting errors or warnings
• JavaScript tests are passing

[shorvath-noaa]

Can you specify what 'dataframes' or 'list' are being referred to here?

[AminTorabi-NOAA]

Updated

[JurgenZach-NOAA]

I'm weighing in here, b/c I'm presently working on the related pydantic check of the gage folders. We do have situations where all of the USACE files are empty, including our beloved Lower Colorado test example. I would advise against throwing an error in such situations. I believe the user needs to be told somewhere if all the USACE files are empty, but there is no reason not to run the simulation.

…

On Fri, May 24, 2024 at 2:21 PM Amin Torabi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/troute-network/troute/nhd_io.py <#768 (comment)>: > + if all_empty: + LOG.debug(f'DataFrames in the list are empty.') + return pd.DataFrame() it ends the function. if its all empty we don't need to continue, we can just return empty dataframe (similar to else: statement) — Reply to this email directly, view it on GitHub <#768 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBPBYNIF2XXLOFJMQCRISPDZD6VNJAVCNFSM6AAAAABIGEC5N2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZYGA3TEMJTGA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[JurgenZach-NOAA]

To be more specific: I understand that we could just turn off reservoir persistence for usace, but if we have a situation where someone wants to run the same model over a long and then a shorter time period, and we happen to not have gage data over the shorter period, then the simulation would throw an error if we disallow empty gage files. Which would be difficult to understand for a user. On Fri, May 24, 2024 at 2:40 PM Jurgen Zach - NOAA Affiliate < ***@***.***> wrote:

…

I'm weighing in here, b/c I'm presently working on the related pydantic check of the gage folders. We do have situations where all of the USACE files are empty, including our beloved Lower Colorado test example. I would advise against throwing an error in such situations. I believe the user needs to be told somewhere if all the USACE files are empty, but there is no reason not to run the simulation. On Fri, May 24, 2024 at 2:21 PM Amin Torabi ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In src/troute-network/troute/nhd_io.py > <#768 (comment)>: > > > + if all_empty: > + LOG.debug(f'DataFrames in the list are empty.') > + return pd.DataFrame() > > it ends the function. if its all empty we don't need to continue, we can > just return empty dataframe (similar to else: statement) > > — > Reply to this email directly, view it on GitHub > <#768 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BBPBYNIF2XXLOFJMQCRISPDZD6VNJAVCNFSM6AAAAABIGEC5N2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZYGA3TEMJTGA> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> >