Diffusive fortran kernel correctly executes diffusive wave on stream segments defined by Python preprocessing #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining diffusive domain including not only mainstem but also connected tributaries by this config file, diffusive.f90 hasn't been executed diffusive wave routing on all the reaches where the config file defines to run diffusive wave on. That's because diffusive.f90 assumes a reach without any its upstream reach to not run diffusive wave on but instead to already have given flow and depth data computed from other routing model, in this case MC. By defining a reach of index j in frnw_g with specified value, for example, 555 for diffusive reach while -555 for already-computed reach, diffusive.f90 now correctly route on all reaches told to run diffusive wave.
Additions
AbstractRouting.py: Select a single cross section topo data with minimum value of cs_id for each stream segment
diffusive_utils_v02.py: Decide a stream reach of index j whether to run diffusive wave or not to run diffusive but have already-computed flow value by MC instead.
diffusive.90: Implement diffusive wave on all the reaches that are told to run diffusive on.
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other