Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper limit on celerity value in diffusive Fortran kernel #756

Merged

Conversation

kumdonoaa
Copy link
Contributor

@kumdonoaa kumdonoaa commented Apr 1, 2024

Too high values of the celerity in the diffusive Fortran kernel often lead to too small (sometimes several orders of magnitude smaller than on second), which virtually freezes the kernel. To prevent it from happening, upper limits on celerity are placed after deriving from the Courant condition with minimum simulation time increment being initially given time step divided by an user-provided numeric value (10 in this case).

Additions

diffusive.f90: Once validated, the user-provided numeric value, for better use, should be directly passed from config yaml or through diffusive_util_v02.py

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@kumdonoaa kumdonoaa merged commit 2b473cf into NOAA-OWP:master Apr 3, 2024
4 checks passed
@kumdonoaa kumdonoaa deleted the diffusive_prevent_toosmall_timestep branch April 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants