Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config issues relating to 'columns' default values and retrieving rfc da parameters #751

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

shorvath-noaa
Copy link
Contributor

Quick updates to config module/retrieval. Set default values for columns if user leaves this parameter blank. This includes a @validator to set defaults based on whether it is a NHDNetwork or HYFeaturesNetwork.

Also fixed retrieving rfc_da parameters in read_geopkg() function. This was looking for these parameters in waterbody_parameters which was the old method. Now looks in data_assimilation_parameters where they actually are for V4.

Additions

network_topology_parameters.py

  • Default values for columns for both NHD and HYFeatures networks
  • @validator to set appropriate default values based on network_type

Removals

Changes

HYFeaturesNetwork.py

  • Updated where rfc_da parameters are retrieved from

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@shorvath-noaa shorvath-noaa merged commit 75528aa into NOAA-OWP:master Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants