Fix config issues relating to 'columns' default values and retrieving rfc da parameters #751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick updates to config module/retrieval. Set default values for
columns
if user leaves this parameter blank. This includes a@validator
to set defaults based on whether it is aNHDNetwork
orHYFeaturesNetwork
.Also fixed retrieving
rfc_da
parameters inread_geopkg()
function. This was looking for these parameters inwaterbody_parameters
which was the old method. Now looks indata_assimilation_parameters
where they actually are for V4.Additions
network_topology_parameters.py
columns
for both NHD and HYFeatures networks@validator
to set appropriate default values based onnetwork_type
Removals
Changes
HYFeaturesNetwork.py
rfc_da
parameters are retrieved fromTesting
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other