Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to reading schism data from file #734

Merged

Conversation

shorvath-noaa
Copy link
Contributor

Fixes how t-route retrieves water depth from SCHISM output files. It now reads both elevation and depth variables and sums them to get water depth.

Additions

Removals

Changes

AbstractNetwork.py

  • read_SCHISM_output() now adds elevation and depth variables from netcdf file to obtain water depth.

.gitignore

  • added *.mod, *.a, & *.c to reduce output when git status is called. This is unrelated to coastal boundary information.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

df = pd.merge(elevation_df, depth_df, on='link')
df['waterdepth'] = df['elevation'] + df['depth']
df = df.drop(['elevation','depth'], axis=1)
df
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

df (Line 1000) can be deleted

Copy link
Contributor

@JurgenZach-NOAA JurgenZach-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no objections.

@shorvath-noaa shorvath-noaa merged commit 189dfa6 into NOAA-OWP:master Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants