simple fix for flowpaths with unavailable 3Dxsec data

[kumdonoaa]

3D channel cross section data currently being developed for diffusive mainstem domains has missing topobathy data for some flowpaths in the domains. The 3D data is based on v20.1 hydrofabric gpkg. To temporarily fix this issue while waiting for more solid update, a simple solution was applied to fill the gap: Basically, a flowpath with no available topobathy data, it borrows the data from the closest upstream flowpath. If the upstream has multiple topobathy data available, then it borrows the most downstream topobathy data. Again, this is a simple and temporary solution for making diffusive module functionally run and need to be updated along the way.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Windows
• Linux
• Browser

Accessibility

• Keyboard friendly
• Screen reader friendly

Other

• Is useable without CSS
• Is useable without JS
• Flexible from small to large screens
• No linting errors or warnings
• JavaScript tests are passing

[AminTorabi-NOAA]

On this line (317) there is a warning that say:

A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead
See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
fill_in_topobathy_df.cs_id = fill_in_topobathy_df.cs_id.replace(cs_id_max,1)

to fix this, change line 316 to fill_in_topobathy_df = pd.DataFrame(temp_df[temp_df.cs_id == cs_id_max])

[kumdonoaa]

Thanks for this update.