Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct subroutine calling in diffusive.f90 and update makefile #709

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

kumdonoaa
Copy link
Contributor

@kumdonoaa kumdonoaa commented Dec 5, 2023

After calling subroutine readXsection, dimension variables for subroutine arguments z_ar_g, bo_ar_g, traps_ar_g, twcc_ar_g was using global variables mxncomp and nlinks defined in module level. However, with intent(in) attribute the global variables weren't allowed to be there. As a solution, the dimension variables are included as the subroutine arguments to get the arrays properly allocated with intent(in) attribute.

src/kernel/diffusive/make hadn't been able to detect this error before even though this issue is related to only synthetic channel cross section lookup table making. But, it was detected using f2py3 in parallel to produce SO (Shared Object) file to cross-check with SO file produced by compiling t-route. Going forward, it is recommended to run, for example, f2py3 -c diffusive.f90 -m diffusive, in parallel to enhance error checking when building SO file from t-route.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@kumdonoaa kumdonoaa merged commit 78adb81 into NOAA-OWP:master Dec 6, 2023
@kumdonoaa kumdonoaa deleted the diffusive_hyfeature_3dxsec branch December 6, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants