Correct subroutine calling in diffusive.f90 and update makefile #709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After calling subroutine readXsection, dimension variables for subroutine arguments z_ar_g, bo_ar_g, traps_ar_g, twcc_ar_g was using global variables mxncomp and nlinks defined in module level. However, with intent(in) attribute the global variables weren't allowed to be there. As a solution, the dimension variables are included as the subroutine arguments to get the arrays properly allocated with intent(in) attribute.
src/kernel/diffusive/make hadn't been able to detect this error before even though this issue is related to only synthetic channel cross section lookup table making. But, it was detected using f2py3 in parallel to produce SO (Shared Object) file to cross-check with SO file produced by compiling t-route. Going forward, it is recommended to run, for example, f2py3 -c diffusive.f90 -m diffusive, in parallel to enhance error checking when building SO file from t-route.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other