Adding lite-restart and lastObs to BMI conversions #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removed some internal verigication code
shorvath-noaa
requested changes
Nov 8, 2023
src/model_DAforcing.py
Outdated
| @@ -131,6 +132,17 @@ def __init__(self, bmi_cfg_file=None): | |||
|
|
|||
| # read in metadata for BMI compliant arrays: | |||
|
|
|||
| if lastobs_file: | |||
There was a problem hiding this comment.
maybe check if self._lastobs_df is not empty here instead of if the file name exists? Not sure if an empty dataframe would cause _bmi_disassemble_lastObs trouble.
src/model_DAforcing.py
Outdated
|
|
||
| (_q0_columnArray, _q0_columnLengthArray, _q0_nCol, \ | ||
| _q0_indexArray, _q0_nIndex, _q0_Array) = \ | ||
| _bmi_disassemble_lite_restart (self._q0,np.float32) |
There was a problem hiding this comment.
Do we need to verify that self._q0 is not empty before calling this function?
src/model_DAforcing.py
Outdated
|
|
||
| (_waterbodyLR_columnArray, _waterbodyLR_columnLengthArray, _waterbodyLR_nCol, \ | ||
| _waterbodyLR_indexArray, _waterbodyLR_nIndex, _waterbodyLR_Array) = \ | ||
| _bmi_disassemble_lite_restart (self._waterbody_df,np.float64) |
There was a problem hiding this comment.
Same here, check if self._waterbody_df is empty?
src/model_DAforcing.py
Outdated
|
|
||
| #testRevert = True | ||
|
|
||
| if (testRevert): |
There was a problem hiding this comment.
Can we remove all the testRevert sections? Keep the text somewhere for later use, but we don't need it in this file anymore.
|
Implemented requested modifications. |
shorvath-noaa
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added lite-restart and lastObs, along the lines of last additions (usgs, usace, etc). Abstract classes will be created at a later stage upon more-complete integration into t-route.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other