Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subset forcings, added missing directories and set flags in yam… #682

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

JurgenZach-NOAA
Copy link
Contributor

…l file to make sure the example runs out of the box

[Short description explaining the high-level reason for the pull request]

Additions

  • Subset forcings for date 0401
  • Empty directories output and restart

Removals

Changes

  • Changes flags in yaml file:
    treamflow_nudging : True
    diffusive_streamflow_nudging : True

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

streamflow_nudging : False
diffusive_streamflow_nudging : False
streamflow_nudging : True
diffusive_streamflow_nudging : True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be false. We aren't doing diffusive routing for now.

@shorvath-noaa
Copy link
Contributor

@JurgenZach-NOAA I don't see the two new subdirectories (restart and output I believe?) Can you add those?

@JurgenZach-NOAA
Copy link
Contributor Author

Corrected both issues: diffusive routing flag and "empty" directories

@hellkite500
Copy link
Contributor

I would be cautious adding too much test data directly to the repository. This can be cleaned up from the history in the future, but it requires a force push and history re write (this has already happened once in this repos history...)

Large domain and test data of this sort should be hosted outside the code base typically and referenced/pulled into test scripts ect. I'm not sure how large the binary files actually are, but having them in the history starts to impact clone performance significantly.

@JurgenZach-NOAA JurgenZach-NOAA merged commit 5463853 into NOAA-OWP:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants