Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature - add github actions ubuntu latest build #670

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

JoshCu
Copy link
Contributor

@JoshCu JoshCu commented Oct 28, 2023

Adds a github action to automatically build and test t-route on ubuntu-latest, python versions 3.9, 3.10, 3.11

breakout from #660

Original Author

@TrupeshKumarPatel Wrote and tested this.

Dependencies

#668
#667

Additions

.github/workflows/ubuntu-latest.yml

  • adds a workflow for ubuntu latest
  • installs latest dependencies from universe
  • clones t-route master latest
  • builds against python 3.9, 3.10, 3.11 in parallel ./compiler.sh no-e
  • tests lower colorado python -m nwm_routing -f -V3 test_AnA.yaml

Testing

  1. on a fork here https://github.com/TrupeshKumarPatel/t-route/actions/runs/6600080606/job/17929735587
  2. also this should trigger it 🤞

Screenshots

image

Notes

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

@shorvath-noaa
Copy link
Contributor

@JoshCu Is this PR still being worked on or is it ready for review/merging?

@JoshCu
Copy link
Contributor Author

JoshCu commented Nov 10, 2023

@JoshCu Is this PR still being worked on or is it ready for review/merging?

I believe so, I'll find out when I undraft this.
And apologies for the delayed response, was super busy with school this week

@JoshCu JoshCu marked this pull request as ready for review November 10, 2023 21:35
@JoshCu
Copy link
Contributor Author

JoshCu commented Nov 10, 2023

since this pr didn't trigger the action I made an identical one on my fork to test it: https://github.com/JoshCu/t-route/actions/runs/6829893436

@shorvath-noaa shorvath-noaa merged commit cbe117f into NOAA-OWP:master Nov 13, 2023
@JoshCu JoshCu deleted the gihub-action_ubuntu branch November 21, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants