Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate troute.config #645

Merged
merged 61 commits into from
Sep 20, 2023

Conversation

shorvath-noaa
Copy link
Contributor

Integrate new config module into t-route. This is used for V4 simulations of t-route. Config module is used in main.py for running via command line and in troute_model.py for running via BMI. It is also used in DAForcing module.

Additions

  • _inpute_handler_v4 function
  • include troute.config when compiling

Removals

  • Deleting old test directory test/hyfeature_01013500/

Changes

  • Rearrange config files and t-route's calls to user provided parameters.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@shorvath-noaa shorvath-noaa marked this pull request as ready for review September 13, 2023 15:52
mattw-nws pushed a commit to NOAA-OWP/ngen that referenced this pull request Sep 14, 2023
…outing (#636)

Overriding failing test (needs NOAA-OWP/t-route#645 to pass) to unblock other workstreams.
@shorvath-noaa shorvath-noaa merged commit 0a1f5c2 into NOAA-OWP:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants