actually fix numpy str type deprecation #634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #623 served only to mute the module attribute/reference issue of
numpy.str
being deprecated. Thenumpy.dtype.str
isn't a suitable replacement ofnumpy.str
, as thestr
attribute here, according to the docs, iswhich is not a compatible string datatype. The below error seen when using this as a
dtype
has been similarly reported while trying to run t-route since merging #623.It seems that native python types are reasonably supported, though they may not be the most efficient. Using
str
for theastype
arg should work, as seen below, this converts to a unicode string.I believe this should close #616 with the default unicode string conversion.