Fix troute-nwm package setup.cfg #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the setup.cfg knows how to properly find the actual package under the `src` dir. Otherwise, a standard install (`pip install troute-nwm/`) won't actually install the module source required (`-e` works/ed cause it just created a link to the src dir, but for actual packaging, it doesn't bundle the package code without this in the config. For reference, check out [this useful reference on src/ layouts](https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#using-a-src-layout)
shorvath-noaa
approved these changes
Feb 2, 2023
shorvath-noaa
added a commit
that referenced
this pull request
Feb 16, 2023
* initial commit * updated Abstract and HyFeatures network objects to use new functions * bug fixes to get hyfeatures to run properly * updates to NHDNetwork and functions in AbstractNetwork * moved renaming param_df column into individual networks, removed cols from input argument for AbstractNetwork * move renaming dataframe columns and terminal codes/connections creation into read_geo_file function for HyFeatures * move functions from ..._preprocess.py files into the network objects as inherent functions * fixed errors in data_assimilation.update() function * t-route on larger hyfeature domain with hybrid routing (#602) * t-route on larger hyfeature domain with hybrid routing * remove debug line Co-authored-by: Dong Kim <donghakim@cheyenne4.cheyenne.ucar.edu> * add 'RoutingScheme' subclass of AbstractNetwork to set MC/diffusive related variables * bug fixes to get test HYfeatures with MC only run working * move build_qlateral_array function from AbstractNetwork to individual networks * bug fixes to get NHDNetwork working with new configuration * modified routing classes to be separate from network classes * edited names of routing objects, consolidated inputs to nwm_route into fewer inputs * edits to diffusive routing * temporary fix for writing CHRTOUT files in serial rather than parallel * minor updates to previous push * Delete RoutingScheme.py * Delete nhd_preprocess.py * Delete hyfeature_preprocess.py * more updates to address comments above * deleted files * Fix troute-nwm package setup.cfg (#603) Make sure the setup.cfg knows how to properly find the actual package under the `src` dir. Otherwise, a standard install (`pip install troute-nwm/`) won't actually install the module source required (`-e` works/ed cause it just created a link to the src dir, but for actual packaging, it doesn't bundle the package code without this in the config. For reference, check out [this useful reference on src/ layouts](https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#using-a-src-layout) * removed loading nhd_preprocess.py as this file was removed * reverse changes to compute_nhd_routing_v02 input arguments * edit to work with redesigned initial_warmstate_preprocess function * move build_forcing_sets() to AbstractNetwork. abstractnetwork_preprocess.py is no longer needed * Delete abstractnetwork_preprocess.py * initial commit * updated Abstract and HyFeatures network objects to use new functions * bug fixes to get hyfeatures to run properly * updates to NHDNetwork and functions in AbstractNetwork * moved renaming param_df column into individual networks, removed cols from input argument for AbstractNetwork * move renaming dataframe columns and terminal codes/connections creation into read_geo_file function for HyFeatures * move functions from ..._preprocess.py files into the network objects as inherent functions * fixed errors in data_assimilation.update() function * add 'RoutingScheme' subclass of AbstractNetwork to set MC/diffusive related variables * bug fixes to get test HYfeatures with MC only run working * move build_qlateral_array function from AbstractNetwork to individual networks * bug fixes to get NHDNetwork working with new configuration * modified routing classes to be separate from network classes * edited names of routing objects, consolidated inputs to nwm_route into fewer inputs * edits to diffusive routing * temporary fix for writing CHRTOUT files in serial rather than parallel * minor updates to previous push * Delete RoutingScheme.py * Delete nhd_preprocess.py * Delete hyfeature_preprocess.py * more updates to address comments above * removed loading nhd_preprocess.py as this file was removed * reverse changes to compute_nhd_routing_v02 input arguments * edit to work with redesigned initial_warmstate_preprocess function * move build_forcing_sets() to AbstractNetwork. abstractnetwork_preprocess.py is no longer needed --------- Co-authored-by: kumdonoaa <54687070+kumdonoaa@users.noreply.github.com> Co-authored-by: Dong Kim <donghakim@cheyenne4.cheyenne.ucar.edu> Co-authored-by: Nels <nels.frazier@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the setup.cfg knows how to properly find the actual package under the
srcdir. Otherwise, a standard install (pip install troute-nwm/) won't actually install the module source required (-eworks/ed cause it just created a link to the src dir, but for actual packaging, it doesn't bundle the package code without this in the config.For reference, check out this useful reference on src/ layouts