Preprocess Hyfeature channel connectivity, forcing, t0, hybrid routing network. #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorvath-noaa
previously approved these changes
Nov 28, 2022
groutr
reviewed
Nov 29, 2022
src/troute-network/troute/nhd_io.py
Outdated
| supernetwork_parameters["columns"] = routelink_attr | ||
| supernetwork_parameters["waterbody_null_code"] = -9999 | ||
| supernetwork_parameters["terminal_code"] = 0 | ||
| supernetwork_parameters["waterbody_null_code"] = -9999 |
There was a problem hiding this comment.
This line appears to be redundant (see L124).
There was a problem hiding this comment.
Thanks. I just removed it.
shorvath-noaa
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unit test for hyfeature network with hybrid channel routing feature (MC and Diffusive routing) was created. First, it updated/created preprocess functions that build hyfeature channel connectivity, lateral flow dataframe, coastal boundary dataframe, t0, and channel connections for hybrid channel routing. Second, necessary domain and channel forcing files were prepared under t-route/test/unit_test_hyfeature/. With configuration file unittest_hyfeature.yaml under the folder, it successfully ran for one upstream reach by MC and two downstream reaches by diffusive routing.
Additions
Removals
Changes
Testing
python3 -m nwm_routing -V4 -f unittest_hyfeature.yaml
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other