a few changes to help with reservoir DA, fixing typo, moving some DA … #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…features into functions
|
@BrianAvant-NOAA |
BrianAvant
approved these changes
Jul 6, 2022
donaldwj
pushed a commit
to donaldwj/t-route
that referenced
this pull request
Jul 6, 2022
…features into functions (NOAA-OWP#570) * Fixed a typo in main.py that allows reservoir persistence to continue across loops * Moved the logic that checks whether or not a reservoir is in the actual network or in the offnetwork_upstreams list PR by @shorvath-noaa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…features into functions
Some minor tweaks related to reservoir DA. Fixed some typos and moved the logic that omits offnetwork_upstreams reservoirs from DA into the _prep_reservoir_da_dataframes function
Additions
-Fixed a typo in main.py that allows reservoir persistence to continue across loops
-Moved the logic that checks whether or not a reservoir is in the actual network or in the offnetwork_upstreams list. This was done in compute_nhd_routing_v02 by changing the waterbody_types_df_sub dataframe. Now it is done in the _prep_reservoir_da_dataframes function which doesn't require editing any objects in compute_nhd_routing_v02
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other