Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve roredered_reaches issue when two independent diffusive mainstem domains are applied #565

Merged

Conversation

kumdonoaa
Copy link
Contributor

@kumdonoaa kumdonoaa commented May 31, 2022

When a single diffusive domain is applied for the hybrid routing in t-route, python dictionary refactored_reaches takes its values as a list of lists of reaches of diffusive mainstem domain. However, when multiple diffusive domains are applied, the dictionary values were somehow melted down to a list of a single list of all diffusive mainstem segments except downstream end segments of tributaries entering the mainstem. This should be still the same format as a list of lists. This is solved now.

Additions

  • Python dictionary refactored_reaches_batch takes a list of lists for each diffusive mainstem defined by a given TW and then keep the form in Python dictionary refactored_reaches.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@kumdonoaa kumdonoaa requested a review from BrianAvant May 31, 2022 16:25
Copy link
Collaborator

@BrianAvant BrianAvant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add changes to src/troute-network/troute/nhd_network_utilities_v02.py from this PR? Then we can merge all at once

@BrianAvant BrianAvant merged commit fe15a53 into NOAA-OWP:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants