Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to handle reservoir persistence #562

Merged
merged 1 commit into from
May 24, 2022

Conversation

shorvath-noaa
Copy link
Contributor

Added some script to allow reservoir persistence. If a reservoir is in the offnetwork_upstream list the reservoir type is set to 1=levelpool. This prevents reservoir DA from occurring twice in separate subnetworks.

Additions

  • Checks if lake id is in offnetwork_upstream list. If so the reservoir type for the given lake id in the subnetwork is changed to levelpool.
  • Unrelated, but a deepcopy is made of the of the subnetwork list because for some reason it was being altered when parallel processing occurs.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@shorvath-noaa
Copy link
Contributor Author

@BrianAvant-NOAA this was the change needed to make usgs persistence work. I confirmed that the LAKEOUT files and CHRTOUT files now match between t-route and WRF-Hydro.

@BrianAvant BrianAvant self-requested a review May 24, 2022 13:59
@BrianAvant BrianAvant merged commit a01b1be into NOAA-OWP:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants