-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare Python & NumPy versions from configure/build time to runtime #558
Conversation
On reading a bit further into this, it will maybe be more straightforward to just do the full-up string comparisons, rather than component-wise comparisons.
|
…me in the built binary
…st those loaded at runtime
8ac83d7
to
b281804
Compare
endfunction() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file's change was something I noticed as I was implementing the main goal of this PR
@@ -29,7 +29,6 @@ target_link_libraries(realizations_catchment PUBLIC | |||
) | |||
|
|||
if(NGEN_ACTIVATE_PYTHON) | |||
target_include_directories(realizations_catchment PUBLIC ${PROJECT_SOURCE_DIR}/extern/pybind11/include) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was something I noticed as I was implementing the main goal of this PR
The PR template checklist says this
Are we actually doing this? This PR has been noted as something that should be communicated to users. I just don't see anything at all in the change log |
I see how this make the compile time python version available but where is the runtime check? I would have expected modification to Ngen.cpp where the runtime check is made. |
I'm assuming @donaldwj found the runtime checks he referred to, but yes, for future reference, they're here: |
Fixes #545
Additions
src/core/NGen_Python_Build_Versions.in]
to have CMake generate a corresponding.cpp
file with the Python/NumPy versionsChanges
Testing
pip install numpy==1.24.0
in my virtual environment after building with 1.25.0 installedChecklist