Public services and new names #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equivalent_change_noaa
updated general mrf items to be gfs specific
…set_flooding_probability
…flooding_probability
Fixed fim data sql issues
…x_inundation_prvi
…5day_max_inundation
…4day_max_inundation
updated ana_coastal
added optional fim config sql_file to config template added gfs 10 day max to mrf coastal stuff updated ana coastal with new sql fim config changes
|
@shawncrawley could you review this? Most of the stuff is just renaming but there are a few changes with regards to lambda functions. Those changes are mainly for adding a new optional "sql_file" argument to the fim_config section of the product configuration. I did this so that I can specify a sql_file to use for the fim_data_prep and reuse files as needed |
This was
linked to
issues
May 11, 2023
4 tasks
shawncrawley
previously approved these changes
May 11, 2023
There was a problem hiding this comment.
I'm trusting in the power of find/replace for most of this. After looking at a handful of changes to product config, SQL and mapx files, I filtered all ".yml", ".sql", and ".mapx" and only looked more in-depth at the non-config files. It all looks good to me.
CoreyKrewson-NOAA
added a commit
that referenced
this pull request
May 18, 2023
Fixed a handful of issues that were introduced from #440. See this PR info for list of changes made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a standard naming convention for all services and creating the 10% FIM services as well.
<model type>_<forecast period?>_<max?>__<domain?>_<noaa?>
Model Type (required): Indicates what model data is being processes. i.e. ana, srf, mrf, rfc, static, etc
Forecast Period (optional): Indicates forecast period being analyzed. For example, the srf configuration of the water model has an 18hr forecast
Max (optional): Indicates if the data being analyzed is the max value across the forecast or not
Product (required): Name of the data product
Domain (optional): Indicates the domain that is being processed. If no domain is present, then the service is for CONUS
NOAA(optional): Indicates if the service is internal or public. All internal services end in “_noaa”
Changes
Uploading service_name_updates.csv…