generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viz - Dependent products postprocess, add states to attribute table, peak flow arrival optimization #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to rfc max stage service
…out a channels alias
This was
linked to
issues
May 3, 2023
Ok, @CoreyKrewson-NOAA - This should be ready for your review now, at your convenience. I ran the sd file script, found one bug, and corrected. I don't think you need to worry about reviewing everything in the sql / mapx files... just take a look specifically at:
|
CoreyKrewson-NOAA
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm packaging up a few general enhancements here that I've been working on, which build upon Corey's recent big pipeline infrastructure update:
Ability to specify a database table that a product postprocess sql file is dependent on (e.g. peak flow arrival time depends on high water arrival time for the 'below high water return time' column, so that the db doesn't have to calculate that twice for each product. Code changes:
Addition of states to all primary service tables / mapx files (not including summary layers at this time, as those can be a little trickier)
Reduced text field lengths everywhere in mapx files to see if that helps with performance (I'll make a card to test between environments once this is deployed).