Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz - Dependent products postprocess, add states to attribute table, peak flow arrival optimization #425

Merged
merged 22 commits into from
May 5, 2023

Conversation

TylerSchrag-NOAA
Copy link
Contributor

@TylerSchrag-NOAA TylerSchrag-NOAA commented May 3, 2023

I'm packaging up a few general enhancements here that I've been working on, which build upon Corey's recent big pipeline infrastructure update:

  • Ability to specify a database table that a product postprocess sql file is dependent on (e.g. peak flow arrival time depends on high water arrival time for the 'below high water return time' column, so that the db doesn't have to calculate that twice for each product. Code changes:

    • initialize pipeline lambda function - peak flow arrival time config files
    • postprocess_sql function logic & custom exception
    • viz pipeline step function - retry logic on that custom exception
  • Addition of states to all primary service tables / mapx files (not including summary layers at this time, as those can be a little trickier)

    • Most sql files in postprocess_sql lambda function
    • Most mapx files in publish_service lambda function
    • New derived db dump file in RDS Bastion
  • Reduced text field lengths everywhere in mapx files to see if that helps with performance (I'll make a card to test between environments once this is deployed).

@TylerSchrag-NOAA
Copy link
Contributor Author

Ok, @CoreyKrewson-NOAA - This should be ready for your review now, at your convenience. I ran the sd file script, found one bug, and corrected. I don't think you need to worry about reviewing everything in the sql / mapx files... just take a look specifically at:

  • postprocess_sql lambda function handler updates
  • sd file update script (I added a little try except to skip group layers)

@CoreyKrewson-NOAA CoreyKrewson-NOAA merged commit 57300ff into ti May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve peak flow arrival time sql Add State to Channels tables / service tables / mapx files
2 participants