Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana nginx #3

Merged
merged 9 commits into from
Feb 4, 2022
Merged

Kibana nginx #3

merged 9 commits into from
Feb 4, 2022

Conversation

RichardCorbett-NOAA
Copy link

@RichardCorbett-NOAA RichardCorbett-NOAA commented Jan 20, 2022

Adding ECS, IAM Role, and LoadBalancer Items to allow access to Kibana

Additions

-ECS, IAM Roles, and ALB for nginx reverse-proxy containers

Removals

-None

Changes

-Added ElasticSearch output to ElasticSearch module
-Added certificate_arn for load balancer cert to env.yaml file

Testing

  1. Successfully ran Terraform Plan

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@RichardCorbett-NOAA
Copy link
Author

Looks like some additional stuff was moved around by running terraform fmt on the Core directory

@RichardCorbett-NOAA RichardCorbett-NOAA changed the title Kibana nginx WIP: Kibana nginx Jan 21, 2022
@RichardCorbett-NOAA RichardCorbett-NOAA changed the title WIP: Kibana nginx Kibana nginx Jan 27, 2022
@RichardCorbett-NOAA
Copy link
Author

Debugging done, ready for review and merge

Copy link
Collaborator

@nickchadwick-noaa nickchadwick-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this feature updates the Terraform version to 3.70, in case this newer version ends up causing issues on deployment.

@RichardCorbett-NOAA RichardCorbett-NOAA merged commit 26783aa into ti Feb 4, 2022
CoreyKrewson-NOAA pushed a commit that referenced this pull request Sep 7, 2023
* Viz Step Function - Moved egis unstaging to not run on past events.

* Changing EC2 services to export to geopackage instead of shapefile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants