Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for grid generation use of mpi operators #98

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

fmalatino
Copy link
Contributor

Description
This PR amends the usage of MPIComm.allreduce in ndsl/grid/generation::MetricTerms._reduce_global_area_minmaxes to use ReductionOperator instances instead of built-in methods.

How Has This Been Tested?
Tested using the tests currently include in the github workflow. An additional test of a numpy backend c12 baroclinic, 1x1 layout run will be added to the pace workflow as well to ensure future commits do not effect model runs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FlorianDeconinck FlorianDeconinck merged commit a75a1d7 into NOAA-GFDL:develop Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants