Ice dynamics

[OlgaSergienko]

In this PR major changes are made in MOM_ice_shelf_dynamics.F90 to calc_shelf_visc() and calc_shelf_driving_stress() to make them work properly on an irregular quadrilateral grid. In MOM_ice_shelf_initialize.F90 changes are made to initialize_ice_thickness_from_file() to correct masks at initialization.

[codecov]

Codecov Report

Merging #35 (4d8d93c) into dev/gfdl (bbb9753) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           dev/gfdl      #35      +/-   ##
============================================
- Coverage     28.97%   28.96%   -0.02%     
============================================
  Files           240      240              
  Lines         71185    71212      +27     
============================================
  Hits          20623    20623              
- Misses        50562    50589      +27     

Impacted Files	Coverage Δ
src/ice_shelf/MOM_ice_shelf_dynamics.F90	0.00% <0.00%> (ø)
src/ice_shelf/MOM_ice_shelf_initialize.F90	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb9753...4d8d93c. Read the comment docs.

[Hallberg-NOAA]

Thank you for these updates. Overall they look like significant improvements. I would be happy to approve these, but first there are a handful of specific comments (already added to the conversation that I would like you to consider. Each of these changes should be easy enough to make, and they should not adversely impact any working test cases, but they will avoid possible problems later and facilitate more extensive testing.

[Hallberg-NOAA]

Thanks for making the updates. These code changes now look good to me, and they should be merged in once the pipeline and TC tests have passed.

[Hallberg-NOAA]

This PR has passed TC testing and passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14370.