Fix data read for on-grid interpolation #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong MOM_read_data interface was being used: a 2D slice of a 3D field was expected, but the interface for a 2D field was being called.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #124 +/- ##
============================================
- Coverage 33.48% 28.78% -4.71%
============================================
Files 262 249 -13
Lines 71362 72991 +1629
Branches 13310 0 -13310
============================================
- Hits 23898 21010 -2888
- Misses 42992 51981 +8989
+ Partials 4472 0 -4472
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
May 20, 2022
|
This has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15618. |
marshallward
pushed a commit
that referenced
this pull request
Feb 28, 2024
update MOM6 to its main 20231218 commit (disable FPEs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong
MOM_read_datainterface was being used: a 2D slice of a 3D field was expected, but the interface for a 2D field was being called.See mom-ocean#1567.