Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections for mixed mode support in AM5 #357

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

uramirez8707
Copy link
Contributor

Description
This PR includes some fixes needed for mixed mode support in AM5:

  1. Return the correct version of the lon and lat in atmosphere_boundary
  2. Fix a typo so that the correct constants in fv_grid_tools.F90 are included
  3. Added missing parenthesis when setting z_bot in get_bottom_mass, this was causing answer changes when using the non-mixed precision version of am5

Fixes # (issue)

How Has This Been Tested?
Ran AM5 with and without mixed precision

Checklist:
Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laurenchilutti laurenchilutti merged commit 8bddaf4 into NOAA-GFDL:dev/gfdl_am5 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants