Expose remap_scalar and remap_dwinds to fv3-jedi #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junwang-noaa
reviewed
Jul 5, 2022
|
@mark-a-potts Would you be able/willing to absorb #202 into this PR? |
|
That would be fine with me. |
Thanks @mark-a-potts |
Made small changes from PR NOAA-GFDL#202 manually.
|
Since it was just two lines, I made the changes manually. They are now
in PR #199.
-M
On 7/25/22 1:16 PM, Rahul Mahajan wrote:
That would be fine with me.
Thanks @mark-a-potts <https://github.com/mark-a-potts>
Do you want a PR or do you want to take the diff and commit it?
—
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4Q2UWLAHDIXSEM5JI2DWTVV3DVHANCNFSM5Z73DMWA>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
--
Mark A. Potts, Ph.D.
NOAA EPIC Lead Software Engineer
RedLine Performance Solutions, LLC
Phone 202-744-9469
***@***.***
***@***.***
|
6 tasks
|
This should be ready now. |
junwang-noaa
approved these changes
Aug 12, 2022
bensonr
approved these changes
Aug 12, 2022
|
If someone could merge this, it would be great. I don't have permissions to do so. Thanks. |
junwang-noaa
pushed a commit
to NOAA-EMC/GFDL_atmos_cubed_sphere
that referenced
this pull request
Oct 21, 2022
* fixes io performance issues by making everyone a reader when io_layout=1,1 adds capability to use FMS feature to ignore data integrity checksums in restarts * rename enforce_rst_cksum to ignore_rst_cksum and change the default value for compatibility * updated UFS/GFS atmosphere.F90 driver as per @BinLiu-NOAA and @junwang-noaa * Regional decomposition test fix (when nrows_blend > 0) (NOAA-GFDL#194) * Add missing instance for hailwat * Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v. * atmosphere.F90 : add hailwat to check dyn_core.F90 : Fix from Jun Wang to correct sync of u,v fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1 * Explanatory comment added * Removed commented code * Clean old code * In fv_fill.F90, use kind_phys for kind_phys instead of hard-coding 8 byte reals. (NOAA-GFDL#193) * Expose remap_scalar and remap_dwinds to fv3-jedi (NOAA-GFDL#199) * changed interface to public * added public * removed source * mods for jedi build * Transfer changes from PR NOAA-GFDL#202 to NOAA-GFDL#199 Made small changes from PR NOAA-GFDL#202 manually. * returned ignore checksum * fixed ignore checksum * Fix several bugs in fv_regional_bc.F90 relating to uninitialized or incorrectly initialized memory. (NOAA-GFDL#219) * fixes and workarounds for uninitialized memory in fv_regional_bc * remove workarounds and fix remaining known bugs in ps_reg * a few more surface pressure bug fixes; now the test case runs in debug mode * workarounds and bug fixes from gnu compiler testing * remove -9999999 commented-out code * quiet the NaNs passed to Atmp%ps * simplify comments and explain snan * use i-1 & j-1 for two-point averages, when available * Replace many changes with PR NOAA-GFDL#220 Co-authored-by: Rusty.Benson <rusty.benson@noaa.gov> Co-authored-by: Ted Mansell <37668594+MicroTed@users.noreply.github.com> Co-authored-by: Rusty Benson <6594772+bensonr@users.noreply.github.com> Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com> Co-authored-by: Mark Potts <33099090+mark-a-potts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routines remap_dwinds and remap_scalar are needed by fv3-jedi, which requires them to be made public in atmos_cubed_sphere. The changes to the CMakeLists.txt file allow the routines to be linked correctly.
Checklist:
Please check all whether they apply or not