Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick of commits from dev/emc to main #187

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

bensonr
Copy link
Contributor

@bensonr bensonr commented Apr 20, 2022

Description
Bringing in PR #167 and PR #173 to the main branch

Fixes # (issue)
Tests will need to be run to ensure compilation and execution for manual CI and SHiELD functional tests

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@bensonr bensonr requested review from kaiyuan-cheng and removed request for gaokun227 April 20, 2022 16:30
@kaiyuan-cheng
Copy link
Contributor

It looks good to me. Thank you.

@MingjingTong-NOAA
Copy link

The merge looks good to me. I did a quick IAU test, and the merge passed the test.

@laurenchilutti laurenchilutti merged commit 998898c into NOAA-GFDL:main Apr 20, 2022
@bensonr bensonr deleted the cpick_iau branch April 21, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants