Support for cloud microphysics hail species #171

MicroTed · 2022-01-28T23:08:27Z

Description

Adds support for hail hydrometeor category (nwat = 7) for 7-class cloud microphysics. Specifically for the NSSL microphysics scheme, but should work for any microphysics that has separate graupel and hail/frozen drops categories.

Related PR for CCPP physics: NCAR/ccpp-physics#761
Related PR for Single Column Model: NCAR/ccpp-scm#277
Related PR of fv3atm: NOAA-EMC/fv3atm#472

How Has This Been Tested?

Tested to work with fv3atm develop branch on Macos (gcc-10) and Unix (NOAA/Jet, Intel compilers)
Cases run with "grad student test" case (2019061518) and RRFS domain tests
Has not yet been ported to dev/gfdl branch, but fv3atm should still compile and run with other suites that have nwat <= 6.

Checklist:

[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[ x] Any dependent changes have been merged and published in downstream modules

Changes follow or are similar to previous work by Tim Supinie @tsupinie, who deserves much of the credit here. Also contributions by @LarissaReames-NOAA

Addresses compile failure when OMP is turned on (e.g., on Hera)

(Removed SFE code for now)

…c-nsslmicro

…in external_ic.F90 to check value of nwat

lharris4 · 2022-01-31T15:44:51Z

model/fv_dynamics.F90

@@ -849,7 +862,44 @@ subroutine fv_dynamics(npx, npy, npz, nq_tot,  ng, bdt, consv_te, fill,
       used = send_data(idiag%id_mdt, dtdt_m, fv_time)
  endif

-  if( nwat==6 ) then
+  if( nwat==7 ) then


This is the right way to add a new nwat to the code. I am hoping that eventually there can be a more generic way to do this though so that we don't need separate hard codings for different numbers of ice categories.

Agreed. Something like metadata for the tracers, where an integer flag could indicate liquid (1), ice (2), or non-hydrometeor (0).
I noticed that the SCM sets 'nwat' in the GFS_typedefs routine. Perhaps a similar approach could be done here and avoid needing to set both imp_physics and nwat in the namelist?

That would work. There should be an easy way for the physics to query the dynamics for the nwat value.

The nwat value is already being shared with the physics during initialization. The same mechanisms used by the IPD is in place for the CCPP, the Init_parm struct has an %nwat entry.

@bensonr Right, nwat is being passed to model%init as intent(in). It looks like it is used before that, so it might take some changes to be able to set it in model%init. Something to look at for a future update?

lharris4

This is a good addition that provides essential functionality (more schemes now have separate hail and graupel categories, something that may be necessary in future global storm resolving models) and correctly follows existing code standards. I approve this merge if it passes the appropriate regression tests.

lharris4 · 2022-01-31T15:45:37Z

model/fv_regional_bc.F90

+            BC_side%q_BC(i,j,k,snowwat) = 0.
+            BC_side%q_BC(i,j,k,graupel) = 0.
+            BC_side%q_BC(i,j,k,hailwat) = 0.
+            if ( BC_side%pt_BC(i,j,k) > 273.16 ) then       ! > 0C all liq_wat


This is a clever way of establishing boundary conditions.

Looking again at this, a separate nwat=7 section seems unnecessary. There can be just one section with

if ( Atm%flagstruct%nwat .eq. 6 .or. Atm%flagstruct%nwat .eq. 7 ) then
if ( Atm%flagstruct%nwat .eq. 7 ) BC_side%q_BC(is:ie,j,1:npz,hailwat) = 0.
do k=1,npz
...

lharris4 · 2022-01-31T15:58:17Z

model/fv_sg.F90

@@ -1878,6 +1904,364 @@ subroutine neg_adj3(is, ie, js, je, ng, kbot, hydrostatic, peln, delz, pt, dp,

 end subroutine neg_adj3

+! TAS: XXX check to make sure this doesn't need any modifications vs neg_adj2 or neg_adj3


It looks like this routine does not actually do any fixing to qh. This might be OK, although then there isn't much reason for the new routine.

The original reason for the neg_adj was because the older GFS physics created negative tracer values, which this then fixed. If the physics is no longer doing that then the routine may be unnecessary.

Yes, good catch. (@tsupinie - thoughts?) The microphysics scheme here should not output negative hail mass values (below-threshold mass values are moved to water vapor), we could call neg_adj3 instead? Should we assume the same for other new microphysics schemes that have hail (nwat=7)?

lharris4 · 2022-01-31T15:58:55Z

tools/coarse_grained_diagnostics.F90

@@ -228,6 +228,14 @@ subroutine populate_coarse_diag_type(Atm, coarse_diagnostics)
    coarse_diagnostics(index)%units = 'kg/kg/s'
    coarse_diagnostics(index)%reduction_method = MASS_WEIGHTED

+    index = index + 1


Thank you for adding this. It would be neat if more people are using the coarse-graining as an output option.

tools/external_ic.F90

lharris4 · 2022-01-31T16:01:51Z

tools/fv_diagnostics.F90

@@ -4443,6 +4472,9 @@ subroutine prt_mass(km, nq, is, ie, js, je, n_g, nwat, ps, delp, q, area, domain
               write(*,*) 'Total snow       ', trim(gn), '=', qtot(snowwat)*ginv
          if (graupel > 0) &
               write(*,*) 'Total graupel    ', trim(gn), '=', qtot(graupel)*ginv
+          if (hailwat > 0) &


Very good to see all of the stdout diagnostics being correctly implemented. You have done a very careful job.

tools/external_ic.F90

lharris4 · 2022-01-31T21:16:29Z

Hi, Ted. Another thing you can do is to check if the 'hailwat' tracer is defined. If the tracer is not defined then get_tracer_index('hailwat') will return a negative value. Lucas

…

On Mon, Jan 31, 2022 at 11:49 AM Ted Mansell ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In model/fv_regional_bc.F90 <#171 (comment)> : > @@ -3808,7 +3811,51 @@ subroutine remap_scalar_nggps_regional_bc(Atm & enddo enddo endif - endif ! data source /= FV3GFS GAUSSIAN NEMSIO/NETCDF and GRIB2 FILE + if ( Atm%flagstruct%nwat .eq. 7 ) then + do k=1,npz + do i=is,ie + qn1(i,k) = BC_side%q_BC(i,j,k,liq_wat) + BC_side%q_BC(i,j,k,rainwat) = 0. + BC_side%q_BC(i,j,k,snowwat) = 0. + BC_side%q_BC(i,j,k,graupel) = 0. + BC_side%q_BC(i,j,k,hailwat) = 0. + if ( BC_side%pt_BC(i,j,k) > 273.16 ) then ! > 0C all liq_wat Looking again at this, a separate nwat=7 section seems unnecessary. There can be just one section with if ( Atm%flagstruct%nwat .eq. 6 .or. Atm%flagstruct%nwat .eq. 7 ) then if ( Atm%flagstruct%nwat .eq. 7 ) BC_side%q_BC(is:ie,j,1:npz,hailwat) = 0. do k=1,npz ... — Reply to this email directly, view it on GitHub <#171 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUQRVD4D4YHCZRWC7V2DQ3UY24RZANCNFSM5NB6624Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

MicroTed · 2022-01-31T22:18:26Z

Another thing you can do is to check if the 'hailwat' tracer is defined. If the tracer is not defined then get_tracer_index('hailwat') will return a negative value

Good point, Lucas. Although currently the assumption is that hail would only be in a 7-class scheme, future ones may not conform to that, so switching toward checking for categories generally may make it easier to incorporate options like P3 in the future. I have experimented with using a combined ice+snow category, as well. This particular section seems to be set up for a special case (expecting only nwat=6), so the mods are just to be sure all bases are covered.

…sed on 'nwat' value

lharris4

The new updates are good. Thanks.

laurenchilutti · 2022-02-16T17:47:32Z

@junwang-noaa This PR has been fully reviewed and is ready to be added to the commit queue and merge. Please let me know when you would like me to merge.

grantfirl · 2022-02-17T16:55:16Z

@MicroTed Since #176 was merged into dev/emc, you will need to merge in the latest dev/emc to your branch please.

MicroTed · 2022-02-17T20:09:16Z

OK, I have updated to dev/emc, but I'm having trouble getting the whole thing to compile (e.g., module_wrt_grid_comp.F90) (also updated fv3atm to current develop)

Turns out to be an issue with io/inline_post_stub.F90 not having subroutine interface up to date compared to inline_post.F90.

junwang-noaa · 2022-02-28T12:54:20Z

@MicroTed The PR#173 was committed, would you please merge to the top of dev/emc branch?

MicroTed · 2022-02-28T15:35:17Z

The PR#173 was committed, would you please merge to the top of dev/emc branch?

Yes, it should be there.

laurenchilutti · 2022-02-28T16:08:54Z

@junwang-noaa I believe this is on the commit queue for today. Can I merge this now?

junwang-noaa · 2022-02-28T16:14:17Z

@laurenchilutti We are still running RT. Please let you know when all the tests finishes.

junwang-noaa · 2022-03-04T15:25:46Z

@laurenchilutti Would you please merge this PR? Thanks

@MingjingTong-NOAA

* Add get_nth_domain_info subroutine * Deallocate local arrays in fv_dyn_bundle_setup * adding back a line that was mistakenly deleted in a previous commit (NOAA-GFDL#166) * Do not print debug messages to stderr * fix for 4diau with iau_filter_increments=T (NOAA-GFDL#167) * fix for 4diau with iau_filter_increments=T * fix time interval for 3DIAU * fix typo in comment * fix bug found in review by @MingjingTong-NOAA * change tnext to integer variable itnext Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov> * Use mpp_error instead of write statements in model/fv_regional_bc.F90 * Attempt at integrating fixes on top of dev/emc branch. (NOAA-GFDL#173) * Support for cloud microphysics hail species (NOAA-GFDL#171) * Incorporated Tim Supinie's updates to handle a hail category (nwat=7) * Added print for hail max/min (non-debug section) * Add hallwat to !OMP shared variables in main loop Addresses compile failure when OMP is turned on (e.g., on Hera) * Update to states as used in SFE2021 (Removed SFE code for now) * Cleanup after rebase * Redo removal of alt. namelist read * Removed tools/module_diag_hailcast.F90 * Fixes from Jili Dong * Add hailwat to tools/external_ic.F90 * Set logic in fv_regional_bc.F90 to match current code; Change logic in external_ic.F90 to check value of nwat * Recommended changes * Check actual index (hailwat) instead of assuming a positive value based on 'nwat' value * Split nwat=7 bits into separate loops (see if it affects nwat=6) Co-authored-by: Larissa Reames <52886575+LarissaReames-NOAA@users.noreply.github.com> Co-authored-by: LarissaReames-NOAA <larissa.reames@noaa.gov> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com> Co-authored-by: Jeff Whitaker <jswhit@fastmail.fm> Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov> Co-authored-by: MatthewPyle-NOAA <48285220+MatthewPyle-NOAA@users.noreply.github.com> Co-authored-by: Ted Mansell <37668594+MicroTed@users.noreply.github.com> Co-authored-by: Larissa Reames <52886575+LarissaReames-NOAA@users.noreply.github.com> Co-authored-by: LarissaReames-NOAA <larissa.reames@noaa.gov>

MicroTed and others added 11 commits October 15, 2021 16:55

Incorporated Tim Supinie's updates to handle a hail category (nwat=7)

a432fc3

Added print for hail max/min (non-debug section)

a55a2fa

Add hallwat to !OMP shared variables in main loop

6737079

Addresses compile failure when OMP is turned on (e.g., on Hera)

Update to states as used in SFE2021

4537e0b

(Removed SFE code for now)

Cleanup after rebase

17b1ddf

Redo removal of alt. namelist read

fae67a7

Removed tools/module_diag_hailcast.F90

7540b9d

Fixes from Jili Dong

191760c

Merge remote-tracking branch 'tedsrepo/feature/nssl-base' into dev/em…

a5adfc5

…c-nsslmicro

Add hailwat to tools/external_ic.F90

84ff530

Set logic in fv_regional_bc.F90 to match current code; Change logic …

5fb5512

…in external_ic.F90 to check value of nwat

MicroTed mentioned this pull request Jan 28, 2022

Feature: NSSL Microphysics support NOAA-EMC/fv3atm#472

Merged

lharris4 reviewed Jan 31, 2022

View reviewed changes

lharris4 approved these changes Jan 31, 2022

View reviewed changes

bensonr reviewed Jan 31, 2022

View reviewed changes

tools/external_ic.F90 Outdated Show resolved Hide resolved

tools/external_ic.F90 Outdated Show resolved Hide resolved

tools/external_ic.F90 Outdated Show resolved Hide resolved

Recommended changes

5e04e62

MicroTed added 2 commits January 31, 2022 17:36

Check actual index (hailwat) instead of assuming a positive value ba…

1aa3098

…sed on 'nwat' value

Split nwat=7 bits into separate loops (see if it affects nwat=6)

f3d071f

laurenchilutti requested review from bensonr and lharris4 February 11, 2022 13:50

lharris4 approved these changes Feb 14, 2022

View reviewed changes

bensonr approved these changes Feb 16, 2022

View reviewed changes

grantfirl mentioned this pull request Feb 17, 2022

Feature: NSSL Microphysics support ufs-community/ufs-weather-model#1032

Merged

16 tasks

Merge remote-tracking branch 'origin/dev/emc' into dev/emc-nsslmicro

4b51c15

Merge remote-tracking branch 'origin/dev/emc' into dev/emc-nsslmicro

f579c12

laurenchilutti merged commit 43f7ed3 into NOAA-GFDL:dev/emc Mar 4, 2022

grantfirl mentioned this pull request Mar 4, 2022

Add NSSL microphysics to the CCPP ufs-community/ufs-weather-model#1079

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for cloud microphysics hail species #171

Support for cloud microphysics hail species #171

MicroTed commented Jan 28, 2022 •

edited

Loading

lharris4 Jan 31, 2022

MicroTed Jan 31, 2022

lharris4 Feb 14, 2022

bensonr Feb 14, 2022

MicroTed Feb 16, 2022

lharris4 left a comment

lharris4 Jan 31, 2022

MicroTed Jan 31, 2022

lharris4 Jan 31, 2022

MicroTed Jan 31, 2022

lharris4 Jan 31, 2022

lharris4 Jan 31, 2022

lharris4 commented Jan 31, 2022 via email

MicroTed commented Jan 31, 2022

lharris4 left a comment

laurenchilutti commented Feb 16, 2022

grantfirl commented Feb 17, 2022

MicroTed commented Feb 17, 2022 •

edited

Loading

junwang-noaa commented Feb 28, 2022

MicroTed commented Feb 28, 2022

laurenchilutti commented Feb 28, 2022

junwang-noaa commented Feb 28, 2022

junwang-noaa commented Mar 4, 2022

		@@ -1878,6 +1904,364 @@ subroutine neg_adj3(is, ie, js, je, ng, kbot, hydrostatic, peln, delz, pt, dp,

		end subroutine neg_adj3

		! TAS: XXX check to make sure this doesn't need any modifications vs neg_adj2 or neg_adj3

Support for cloud microphysics hail species #171

Support for cloud microphysics hail species #171

Conversation

MicroTed commented Jan 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lharris4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lharris4 commented Jan 31, 2022 via email

MicroTed commented Jan 31, 2022

lharris4 left a comment

Choose a reason for hiding this comment

laurenchilutti commented Feb 16, 2022

grantfirl commented Feb 17, 2022

MicroTed commented Feb 17, 2022 • edited Loading

junwang-noaa commented Feb 28, 2022

MicroTed commented Feb 28, 2022

laurenchilutti commented Feb 28, 2022

junwang-noaa commented Feb 28, 2022

junwang-noaa commented Mar 4, 2022

MicroTed commented Jan 28, 2022 •

edited

Loading

MicroTed commented Feb 17, 2022 •

edited

Loading