-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Issue Templates to Repository #105
Conversation
Pardon my question, but how useful are these things, really? I see a lot of times the EMC submissions leave a lot of the boilerplate text in-place, and it's hard to scan the resulting issues/reports/requests for the important stuff. |
Agreed. Same for ufs-weather-model, fv3atm, ... Unless we code managers are strict and reject PRs that don't have the templates filled out, it will add more confusion than it helps. |
I presume that a GitHub action could be set up to auto-reject the
incomplete PRs? :-) That would certainly save a lot of work.
…On Tue, Jun 1, 2021 at 10:33 AM Dom Heinzeller ***@***.***> wrote:
Pardon my question, but how useful are these things, really? I see a lot
of times the EMC submissions leave a lot of the boilerplate text in-place,
and it's hard to scan the resulting issues/reports/requests for the
important stuff.
Agreed. Same for ufs-weather-model, fv3atm, ... Unless we code managers
are strict and reject PRs that don't have the templates filled out, it will
add more confusion than it helps.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVCOSRIIE7FCOCP3GC3TQTVRLANCNFSM454UOXOQ>
.
|
Not sure about the GitHub action, but with the issue templates in place, the time for being nice can be over. The code managers (Lauren and I) can reject any PR that doesn't have a corresponding issue along with any incomplete submission. |
I will bring this up at the CCPP developer meeting today as well - would be nice to be consistent across the different repositories involved in the UFS. |
Thanks for the comments, we will discuss the issues with other ufs/fv3 code
managers. Currently we need lots of user support to help developers to
create clean and complete issues.
…On Tue, Jun 1, 2021 at 11:35 AM Dom Heinzeller ***@***.***> wrote:
Not sure about the GitHub action, but with the issue templates in place,
the time for being nice can be over. The code managers (Lauren and I) can
reject any PR that doesn't have a corresponding issue along with any
incomplete submission.
I will bring this up at the CCPP developer meeting today as well - would
be nice to be consistent across the different repositories involved in the
UFS.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPR6J4JIHLFEPAAVSLTQT425ANCNFSM454UOXOQ>
.
|
Description
This PR adds Issue Templates to be used in the GFDL_atmos_cubed_sphere repository. There are 3 templates being included: feature request, support request, and bug report. These templates are derived from the FMS repository's issue templates.
Fixes # (issue)
How Has This Been Tested?
These templates can be tested by reviewers by navigating to my fork and creating test issues. You will have the choice of the 3 templates when you go to create an issue. I have tested this with 3 separate issues in my fork:
bug report test
feature request test
support request test test
Checklist:
Please check all whether they apply or not