#1 - Create full_coupler_mod #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlee03 why not jus merge into main? Why are you using a coupler_dev branch? |
|
@thomas-robinson I don't want to be the person who broke main 😁 |
|
|
thomas-robinson
requested changes
Mar 20, 2024
full/coupler_main.F90
Outdated
Comment on lines
551
to
579
| #ifdef FREDB_ID | ||
| #define xstr(s) str(s) | ||
| #define str(s) #s | ||
| fredb_id = xstr(FREDB_ID) | ||
| #else | ||
| #warning "FREDB_ID not defined. Continuing as normal." | ||
| fredb_id = 'FREDB_ID was not defined (e.g. -DFREDB_ID=...) during preprocessing' | ||
| #endif | ||
|
|
||
| arg_count = command_argument_count() | ||
| DO i=0, arg_count | ||
| CALL get_command_argument(i, arg, status=status) | ||
| if (status .ne. 0) then | ||
| write (error_unit,*) 'get_command_argument failed: status = ', status, ' arg = ', i | ||
| stop 1 | ||
| end if | ||
|
|
||
| if (i .eq. 0) then | ||
| executable_name = arg | ||
| else if (arg == '--fredb_id') then | ||
| write (output_unit,*) TRIM(fredb_id) | ||
| stop | ||
| end if | ||
| END DO | ||
|
|
||
| if (arg_count .ge. 1) then | ||
| write (error_unit,*) 'Usage: '//TRIM(executable_name)//' [--fredb_id]' | ||
| stop 1 | ||
| end if |
There was a problem hiding this comment.
You need to add this to the description of this PR or you need to open a new PR that has a more general cleanup/removal of parts of the code
There was a problem hiding this comment.
Added back in and ready for another round of review!
|
@thomas-robinson @bensonr, any additional changes? |
|
@thomas-robinson , BEHOLD, everything passes! READY FOR REVIEW |
thomas-robinson
approved these changes
May 13, 2024
uramirez8707
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
module usestatements and subroutine definitions found incoupler_main.F90have been moved to a newly createdfull_coupler_modmodule. In this version offull_coupler_modmost of the imported procedures have been marked aspublicbut as coupler subroutines are defined, many of these procedures will become private.Experiments in AM4, AM5, CM4, SPEAR, OM4_extra, and OMIP_CORE2 xmls for regression testing pass.