Update 'devbuild.sh', module files, and directory names #9

chan-hoo · 2023-07-03T11:03:24Z

DESCRIPTION OF CHANGES:

Updates devbuild.sh and adds devclean.sh
Changes the directory names: bin -> exec, src -> sorc
Moves the module files to modulefiles and updates modules with the latest ones.
Updates the hash of UFS_UTILS.

TESTS CONDUCTED:

Machines/platforms: wcoss2 (cactus), hera, orion

ISSUE:

Partially fixes the issue(s) mentioned in Establish a dev-sci branch that reproduces answers from current RRFS_dev1 system #3

chan-hoo · 2023-07-03T11:16:54Z

@MatthewPyle-NOAA, could you give the code owners (listed in .github/CODEOWNERS) the write access to this repository? Then, they will be set as the default PR reviewers when a new PR is submitted. I can see the error message This CODEOWNERS file contains errors. This is because they don't have the write access. If you think the file (.github/CONDEOWNERS) needs to be modified, please let me know.

chan-hoo · 2023-07-03T11:20:28Z

README.md

+```
+./devbuild.sh -p=[machine]
+```
+where `[machine]` is `wcoss2`, `hera`, `orion`, or `jet`.


As can be seen in this new README file, this PR makes the build steps work up to Step 3 on wcoss2, hera and orion.

@chan-hoo Thank you so much for working on this so quickly. Since dev-sci will be used by both GSL and EMC, I add @hu5970 as a reviewer so that GSL can get an understanding of how the modification will affect the future update of RRFS-B on JET.

Thanks. As described above, the rrfs-workflow does not work yet (even with this PR). This PR only makes the 'build' step work well. I've tested it on wcoss2, hera, and orion. I don't have access to Jet. Are there any other machines to be tested?

@chan-hoo I think the RRFS workflow for operations will only need to be supported on WCOSS2, Hera, Jet, and Orion. So at some point we will want to remove the logic for the other non-supported platforms.

ShunLiu-NOAA · 2023-07-03T13:52:35Z

@hu5970 Please review the modifications and let's consider the new development in dev-sci.

MatthewPyle-NOAA · 2023-07-05T13:51:33Z

@MatthewPyle-NOAA, could you give the code owners (listed in .github/CODEOWNERS) the write access to this repository? Then, they will be set as the default PR reviewers when a new PR is submitted. I can see the error message This CODEOWNERS file contains errors. This is because they don't have the write access. If you think the file (.github/CONDEOWNERS) needs to be modified, please let me know.

@chan-hoo I'll try to get this sorted out

MatthewPyle-NOAA

@chan-hoo Changes look good to me. I left a few comments, mostly about stuff that I think needs to be removed (JEDI, metplus, etc.), but maybe not critical to fix at this stage.

jobs/JREGIONAL_JEDIENVAR_IODA

jobs/JREGIONAL_RUN_PYTHON_GRAPHICS

ush/bash_utils/define_macos_utilities.sh

ush/bash_utils/eval_METplus_timestr_tmpl.sh

ush/constants.sh

ush/setup.sh

MatthewPyle-NOAA

No objections from me from looking at changes...but hopefully Ben Blake can weigh in after more testing.

BenjaminBlake-NOAA · 2023-07-06T17:44:21Z

@MatthewPyle-NOAA @chan-hoo I can definitely look over all these changes more thoroughly tomorrow morning. The build process worked well for me on WCOSS2 and Hera. Once I get access to the wrfruc project on Jet I will test building the code there and submit my final approval. Hopefully that won't take more than a day or two!

chan-hoo · 2023-07-06T18:13:09Z

Sorry. Something wrong. I'll fix the dismiss and label issue.

chan-hoo · 2023-07-06T18:15:07Z

@MatthewPyle-NOAA, I don't know what happened here. I didn't dismiss your approval. Can you fix this?

MatthewPyle-NOAA

Giving conditional approval, pending Ben Blake's testing.

chan-hoo · 2023-07-06T18:18:50Z

Giving conditional approval, pending Ben Blake's testing.

Thank you!

BenjaminBlake-NOAA · 2023-07-06T19:00:37Z

.github/CODEOWNERS

@@ -3,7 +3,7 @@

 # These owners will be the default owners for everything in the repo.
 #*       @defunkt
-*       @MatthewPyle-NOAA @ShunLiu-NOAA @JacobCarley-NOAA @chan-hoo @BenjaminBlake-NOAA @RatkoVasic-NOAA @JiliDong-NOAA @hu5970
+*       @NOAA-EMC/RRFS/RRFS-devs


I know some work was done to update the CODEOWNERS file, but GitHub is still saying the file contains errors. Should we revert back to the previous version which listed our individual usernames?

BenjaminBlake-NOAA · 2023-07-06T19:01:13Z

devclean.sh

+usage () {
+cat << EOF_USAGE
+
+Clean the UFS-SRW Application build


I would suggest replacing UFS-SRW application with RRFS here.

BenjaminBlake-NOAA · 2023-07-06T19:01:35Z

etc/lmod-setup.csh

+
+OPTIONS:
+   PLATFORM - name of machine you are building on
+      (e.g. cheyenne | hera | jet | orion | wcoss2 )


I would remove the reference to Cheyenne.

BenjaminBlake-NOAA · 2023-07-06T19:01:54Z

etc/lmod-setup.sh

+
+OPTIONS:
+   PLATFORM - name of machine you are building on
+      (e.g. cheyenne | hera | jet | orion | wcoss2 )


I would also remove this reference to Cheyenne.

BenjaminBlake-NOAA · 2023-07-06T19:02:23Z

ush/load_modules_wflow.sh

+
+OPTIONS:
+   PLATFORM - name of machine you are on
+      (e.g. cheyenne | hera | jet | orion | wcoss2 )


I would remove Cheyenne as an option here as well.

BenjaminBlake-NOAA

@chan-hoo I've finished reviewing all of the changes, they look great! I have a couple of general comments which I will leave here, and I added a few other suggestions to specific files. I am not going to formally submit my approval just yet but I will do that once I get access to Jet and can build the workflow there.

I agree with Matt about removing JEDIENVAR_IODA and RUN_PYTHON_GRAPHICS, but that can be done later.
Once we start running/testing the workflow and jobs, we should change python_srw to python_rrfs and SRW_ENV to RRFS_ENV in modulefiles/tasks. But I think that change is outside the scope of this PR.

MatthewPyle-NOAA · 2023-07-07T11:22:52Z

Are you ready for this to be merged, @chan-hoo ?

chan-hoo · 2023-07-07T11:50:01Z

@MatthewPyle-NOAA, whenever I submit a new commit, the existing reviewer's approvals are dismissed. I think we need to change some settings.

chan-hoo · 2023-07-07T11:57:26Z

I found out your approval was only dismissed by a new commit. I think the code owner' (new) review is required for any new commits.

MatthewPyle-NOAA · 2023-07-07T12:02:48Z

@chan-hoo I found this issue, but don't see the option described to stop the dismissal of reviews. I'll reapprove.

MatthewPyle-NOAA

Giving another approval...

chan-hoo · 2023-07-07T12:08:51Z

Thanks, I think it is ready to be merged now.

chan-hoo added 11 commits June 30, 2023 23:55

basic update

541bc1c

additional change to rrfs-workflow

cff6cfd

extran change in dev

dee2ce9

update modulefiles

a6f0d42

fix typo

0cb2327

remove env and update hash of ufs-utils

55275a1

change libpng and add prod_utils

0a803e2

update README file

a80267e

fix typo

02762b2

simplify PR template

98a6b9b

fix typo

f1ec66d

chan-hoo requested a review from MatthewPyle-NOAA as a code owner July 3, 2023 11:03

chan-hoo requested review from BenjaminBlake-NOAA and ShunLiu-NOAA July 3, 2023 11:17

chan-hoo commented Jul 3, 2023

View reviewed changes

change dir structure and name

56b1984

ShunLiu-NOAA requested a review from hu5970 July 3, 2023 13:45

update task module files for wcoss2

a76f768

chan-hoo added 9 commits July 3, 2023 16:36

update task module files for hera

60d40fb

update task module files for jet and orion

424b9ae

fix dir structure in generation scripts

91156de

change DIR to dir to meet NCO standards

50d98fe

update functions

f6c479a

remove preamble

cb5c735

remove DEBUG

49206fc

fix launch script

3978658

add non-DA xml for testing

0dee55e

MatthewPyle-NOAA reviewed Jul 6, 2023

View reviewed changes

remove unnecessary utilities

d68d41e

MatthewPyle-NOAA previously approved these changes Jul 6, 2023

View reviewed changes

fix failure on make_grid

9e4da76

chan-hoo dismissed MatthewPyle-NOAA’s stale review via 9e4da76 July 6, 2023 18:12

chan-hoo added the bug Something isn't working label Jul 6, 2023

chan-hoo removed the bug Something isn't working label Jul 6, 2023

MatthewPyle-NOAA previously approved these changes Jul 6, 2023

View reviewed changes

BenjaminBlake-NOAA reviewed Jul 6, 2023

View reviewed changes

BenjaminBlake-NOAA approved these changes Jul 7, 2023

View reviewed changes

address Ben's comments

2ab1165

chan-hoo dismissed MatthewPyle-NOAA’s stale review via 2ab1165 July 7, 2023 11:47

chan-hoo requested a review from JacobCarley-NOAA as a code owner July 7, 2023 11:48

MatthewPyle-NOAA approved these changes Jul 7, 2023

View reviewed changes

MatthewPyle-NOAA merged commit 0f4df16 into NOAA-EMC:dev-sci Jul 7, 2023

chan-hoo deleted the bugfix/dev_sci branch July 8, 2023 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update 'devbuild.sh', module files, and directory names #9

Update 'devbuild.sh', module files, and directory names #9

chan-hoo commented Jul 3, 2023

chan-hoo commented Jul 3, 2023

chan-hoo Jul 3, 2023

ShunLiu-NOAA Jul 3, 2023

chan-hoo Jul 3, 2023 •

edited

Loading

BenjaminBlake-NOAA Jul 5, 2023

ShunLiu-NOAA commented Jul 3, 2023

MatthewPyle-NOAA commented Jul 5, 2023

MatthewPyle-NOAA left a comment

MatthewPyle-NOAA left a comment

BenjaminBlake-NOAA commented Jul 6, 2023

chan-hoo commented Jul 6, 2023

chan-hoo commented Jul 6, 2023

MatthewPyle-NOAA left a comment

chan-hoo commented Jul 6, 2023

BenjaminBlake-NOAA Jul 6, 2023

chan-hoo Jul 7, 2023

BenjaminBlake-NOAA Jul 6, 2023

chan-hoo Jul 7, 2023

BenjaminBlake-NOAA Jul 6, 2023

chan-hoo Jul 7, 2023

BenjaminBlake-NOAA Jul 6, 2023

chan-hoo Jul 7, 2023

BenjaminBlake-NOAA Jul 6, 2023

chan-hoo Jul 7, 2023

BenjaminBlake-NOAA left a comment

MatthewPyle-NOAA commented Jul 7, 2023

chan-hoo commented Jul 7, 2023

chan-hoo commented Jul 7, 2023

MatthewPyle-NOAA commented Jul 7, 2023

MatthewPyle-NOAA left a comment

chan-hoo commented Jul 7, 2023

Update 'devbuild.sh', module files, and directory names #9

Update 'devbuild.sh', module files, and directory names #9

Conversation

chan-hoo commented Jul 3, 2023

DESCRIPTION OF CHANGES:

TESTS CONDUCTED:

ISSUE:

chan-hoo commented Jul 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chan-hoo Jul 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShunLiu-NOAA commented Jul 3, 2023

MatthewPyle-NOAA commented Jul 5, 2023

MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

BenjaminBlake-NOAA commented Jul 6, 2023

chan-hoo commented Jul 6, 2023

chan-hoo commented Jul 6, 2023

MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

chan-hoo commented Jul 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

MatthewPyle-NOAA commented Jul 7, 2023

chan-hoo commented Jul 7, 2023

chan-hoo commented Jul 7, 2023

MatthewPyle-NOAA commented Jul 7, 2023

MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

chan-hoo commented Jul 7, 2023

chan-hoo Jul 3, 2023 •

edited

Loading