Series of small WCOSS2 updates - round 8 #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove COMINice and COMINwnd from JGLOBAL_WAVE_POST_SBS - wave developer confirmed they are no longer used/needed Refs: NOAA-EMC#399
- update the memory setting in the get_resources block of workflow_utils.py to accept a separate gfs memory value - this change now allows gfs suite jobs to set different memory requirements compared to the gdas suite version of the job - this aligns the memory setting with how other resource values are differentiated between the suites Refs: NOAA-EMC#399
- add the missing get_awipsgroups function into the fcstonly version of the setup_workflow script (setup_workflow_fcstonly.py) - needed to add gfsawips jobs to xml in fcstonly mode Refs: NOAA-EMC#399
- remove unneeded MP_PULSE=0 setting; it's set in JJOB script - add if-block to set NTASKS=$NTASK_gfs if CDUMP=gfs; this allows waveprep to run with different # of tasks in gfs suite compared to gdas suite settings Refs: NOAA-EMC#399
- add COMIN_OBS/COMIN_GES_OBS setting to config.base.emc.dyn for running analysis/enkf jobs in emc/dev mode; NCO mode uses compath.py in ops - COMIN_OBS/COMIN_GES_OBS needs to be set before use when in emc/dev mode - to support COMIN_GES_OBS setting in config.base values of GDATE, gPDY, gcyc, and GDUMP need to be set before config.base is read, therefore have added GDATE/gPDY/gcyc/GDUMP to generated rocoto xml envvars - CDUMP/PDY/cyc/CDUMP already in rocoto xml for similar job support - these changes should not impact NCO mode in ops, only emc/dev mode Refs: NOAA-EMC#399
aerorahul
reviewed
Jan 25, 2022
aerorahul
approved these changes
Jan 25, 2022
kayeekayee
pushed a commit
to kayeekayee/global-workflow
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings in some changes for the WCOSS2 port:
NTASKS_gfssupport inWCOSS2.env(for waveprep job that needs to run with different # of tasks in gfs suite compared to gdas suite - need to update wave scripts to not use NTASKS in future work, this is just a patch for WCOSS2 ops).COMINiceandCOMINwndfromjobs/JGLOBAL_WAVE_POST_SBS.ush/rocoto/workflow_utils.py, previously only accepted one memory setting for both gdas and gfs suite versions of a job, now users can set memory separately between the gdas and gfs suite versions of the same job. This aligns with similar support for the other resource variables.get_awipsgroupsfunction to setup_workflow_fcstonly.py.COMIN_OBSandCOMIN_GES_OBSin config.base.emc.dyn to properly set both variables when run in emc/dev mode. These two variables will be set via compath.py in NCO mode so this change is only to support emc/dev mode users. Will be working to change this in the future, want to use compath.py everywhere and not need emc/nco mode checks.GDATE,GDUMP,gPDY, andgcyc. This supports the newCOMIN_GES_OBSvariable, which needs to be built off of these variables before being used. This aligns with similar support in the rocoto xml for setting theCDATE,CDUMP,PDY,cycvariables used by all jobs.Refs: #398, #399
Type of change
Port updates and maintenance.
How Has This Been Tested?
By rerunning affected jobs in test on Dogwood.