Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates to use new issue type field #3369

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Feb 24, 2025

Description

GitHub added a new issue type field to indicate whether an issue is a bug, feature, or task. This switches issue templates to use this new field instead of labels. Also adds issue to "global-workflow development" project.

Resolves #3368

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

N/A, GitHub template only

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

GitHub added a new issue type field to indicate whether an issue is
a bug, feature, or task. This switches issue templates to use this
new field instead of labels.

Resolves NOAA-EMC#3368
@DavidHuber-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA To test this PR, I merged it into https://github.com/DavidHuber-NOAA/global-workflow @develop. However, when I try to create an issue after merging, I am greeted with just the basic GitHub provided template:

Screenshot from 2025-02-24 18-11-49

Before the merge, the issue template under https://github.com/DavidHuber-NOAA/global-workflow matched NOAA-EMC's.

@@ -1,6 +1,7 @@
name: NCO Bug Report
description: Report something that is incorrect or broken
labels: ["nco-bug", "triage"]
type: ["bug"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is type supposed to be a string rather than a list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right

@DavidHuber-NOAA
Copy link
Contributor

Hmm, that didn't seem to fix it in my test repository. I'm still seeing just the GitHub default issue.

@WalterKolczynski-NOAA
Copy link
Contributor Author

Made one more attempt and also added auto-add to project.

I think the issue may be that project type is an org-level setting, and personal accounts don't have those.

Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test repository is still unable to bring up the templates. However, you may be right about the project types. I'm OK with merging this PR and seeing if it works.

@DavidHuber-NOAA
Copy link
Contributor

Feel free to merge this when you're ready @WalterKolczynski-NOAA.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ac21a9f into NOAA-EMC:develop Feb 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to new issue type field
2 participants