Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KateFriedman-NOAA
requested changes
Feb 24, 2025
|
|
||
| export oznstat="${COM_ATMOS_ANALYSIS}/gdas.t${cyc}z.oznstat" | ||
| export TANKverf_ozn=${TANKverf_ozn:-${COM_ATMOS_OZNMON}} | ||
| export oznstat="${COMOUT_ATMOS_ANALYSIS}/gdas.t${cyc}z.oznstat" |
There was a problem hiding this comment.
COMOUT_ATMOS_ANALYSIS should be a COMIN. This is setting the path of an input file (oznstat) for the GSI monitoring package.
| if [[ ! -d ${TANKverf_rad} ]]; then mkdir -p -m 775 ${TANKverf_rad} ; fi | ||
| if [[ ! -d ${TANKverf_radM1} ]]; then mkdir -p -m 775 ${TANKverf_radM1} ; fi | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
| COMOUT_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL |
There was a problem hiding this comment.
Same as other comment, COMOUT_ATMOS_ANALYSIS should be a COMIN.
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
| COMOUT_ATMOS_RADMON:COM_ATMOS_RADMON_TMPL | ||
| YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx \ | ||
| COMOUT_ATMOS_RADMON_PREV:COM_ATMOS_RADMON_TMPL |
There was a problem hiding this comment.
COMOUT_ATMOS_RADMON_PREV is a PREV COM variable. Double check if this should be a COMIN or COMOUT.
Comment on lines
-26
to
+28
| if [[ ! -d ${TANKverf_ozn} ]]; then mkdir -p -m 775 ${TANKverf_ozn} ; fi | ||
| if [[ ! -d ${TANKverf_ozn} ]]; then mkdir -p ${TANKverf_ozn} ; fi |
There was a problem hiding this comment.
Was it requested to remove the -m 775 from the mkdir commands in the two scripts in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global JGDAS_ATMOS_VERFOZN and JGDAS_ATMOS_VERFRAD jobs and associated bash and python scripts
Refs #2451
Type of change
Change characteristics
How has this been tested?
Checklist