Replace WAVECUR_DID variable with "rtofs" #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per NCO guidance in bugzilla 1227 discussion Refs NOAA-EMC#1246
JessicaMeixner-NOAA
approved these changes
Feb 19, 2025
WalterKolczynski-NOAA
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the remaining requested change that resolves bugzilla 1227. Per NCO guidance in bugzilla 1227 discussion, this PR removes the
WAVECUR_DIDvariable and replaces it with hardcoded "rtofs". This matches with how the system handles obsproc paths with the hardcoded "obsproc" text.The other aspects of bugzilla 1227 have been remedied through other PRs that removed the old
COMROOTp2references and renamedCOMvariables.The waveprep job is currently disabled in
developso CI is moot. However, a sanity check was done by running the C48_S2SW CI test on Hera.Resolves #1246
Type of change
Bugzilla resolution
Change characteristics
Wave script updates
How has this been tested?
C48_S2SW CI test on Hera