Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI GitHub pipeline (hotfix) update for fetching repo name #3084

Merged
merged 3 commits into from
Nov 12, 2024
Merged

CI GitHub pipeline (hotfix) update for fetching repo name #3084

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3e676a
created bug on last update to the GitHub control file for the CI disp…
Nov 8, 2024
bfe0df6
Merge branch 'NOAA-EMC:develop' into hotfix/gh_action_fetch-branch
TerrenceMcGuinness-NOAA Nov 12, 2024
0671456
updated typo of dropped $ on GitHub env var for repo
Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pw_aws_ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ jobs:
id: get-branch
run: |
pr_number=${{ github.event.inputs.pr_number }}
repo={{ github.repository }}
if [ "$pr_number" -eq "0" ]; then
branch=${{ github.event.inputs.ref }}
repo=${{ github.repository }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused by the syntax used here with {{}} and $. Is this Jinja or is this specific syntax for GitHub workflows?

To retain consistency, I'm guessing that this should be

Suggested change
repo={{ github.repository }}
if [ "$pr_number" -eq "0" ]; then
branch=${{ github.event.inputs.ref }}
repo=${{ github.repository }}
repo=${{ github.repository }}
if [ "$pr_number" -eq "0" ]; then
branch=${{ github.event.inputs.ref }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ${{ gitsutff }} is specific GitHub syntax, and yes line 75 was a typo

else
branch=$(gh pr view $pr_number --repo $repo --json headRefName --jq '.headRefName')
repo_owner=$(gh pr view $pr_number --repo $repo --json headRepositoryOwner --jq '.headRepositoryOwner.login')
Expand Down
Loading