Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gefs C48 on Azure #2881

Merged
merged 84 commits into from
Sep 13, 2024
Merged

Support gefs C48 on Azure #2881

merged 84 commits into from
Sep 13, 2024

Conversation

weihuang-jedi
Copy link
Contributor

@weihuang-jedi weihuang-jedi commented Aug 30, 2024 •
edited
Loading

Support global-worflow GEFS C48 on Azure

Description

Make env. var. and yaml file changes, so global-workflow GEFS C48 case can run properly on Google Cloud.

Resolves #2882

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? YES
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Example:

  • Clone and build on Azure
  • GEFS C48 test on Azure

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

weihuang-jedi and others added 30 commits June 18, 2024 23:05
@weihuang-jedi
compiled OK now
103f2c4
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into aws-forecast-only
916ff6c
@weihuang-jedi
re-test on aws with fewer changes
b0ac406
@weihuang-jedi
make change in tasks.py to avoid error finding libiomp5.so problem
3de972f
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into aws-forecast-only
8308375
@weihuang-jedi
add comments so the reviewers know that these changes are for AWS, an…
bc4c4a8 
…d hope can provide a better way
@weihuang-jedi
Merge branch 'aws-forecast-only' of ssh://github.com/NOAA-EPIC/global…
924aede 
…-workflow-cloud into aws-forecast-only
@weihuang-jedi
add comments so the reviewers know that these changes are for AWS, an…
b724937 
…d hope can provide a better way
@weihuang-jedi
reverse config.resource changes, and memory restriction on AWS
12ab29f
@weihuang-jedi
sync with emc repo
adff250
@weihuang-jedi
move common data to a shared place
2290ea2
@weihuang-jedi
use ICs from s3-bucket
cd2c8e7
@weihuang-jedi
Merge branch 'develop' into aws-forecast-only
4e144e5
@weihuang-jedi
change as suggested by reviewer
46e3ef5
@weihuang-jedi
sync with develop
32f13eb
@weihuang-jedi
sync sorc/ufs_model.fd
a34a4c8
@weihuang-jedi
remove mpmd_opt from APRUN_UFS
44011a3
@weihuang-jedi
mpmd_opt and switch off tracker/genesis default for AWS
965ec80
@weihuang-jedi
add TODO
3ce268e
@weihuang-jedi
remove ncl version on AWS
f03ac78
@weihuang-jedi
Merge remote-tracking branch 'origin/develop' into aws-forecast-only
007a56b
@weihuang-jedi
sync ufs_model
2f6ec6e
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into aws-forecast-only
dba83a7
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into aws-forecast-only
24fe804
@weihuang-jedi
sync and remove gempak from noaacloud
e8a2e0f
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into aws-forecast-only
4013eb1
@weihuang-jedi
update modules hash
a548c7f
@weihuang-jedi
update module hash
d37e646
@weihuang-jedi
use bucket
2a80162
@weihuang-jedi
remove /scratch1, but kept TODO
fa44862
@weihuang-jedi weihuang-jedi marked this pull request as ready for review August 30, 2024 20:29
aerorahul
aerorahul requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything except 1 thing looks good.

aerorahul
aerorahul reviewed Sep 3, 2024
View reviewed changes
aerorahul
aerorahul previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@aerorahul
Copy link
Contributor

@weihuang-jedi The PR looks good, but it appears has some conflicts. If you resolve these, we will merge this.

aerorahul
aerorahul approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit d866982 into NOAA-EMC:develop Sep 13, 2024
5 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 16, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/parallel_metp
91c0ffe 
* origin/develop:
  Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917)
  Cleanup job for GEFS (NOAA-EMC#2919)
  Build GDASApp and unset memory in Gaea-C5 xml files (NOAA-EMC#2912)
  add 1 deg ocean/ice info to parm/config/gfs/config.resources (NOAA-EMC#2922)
  Support gefs C48 on Azure (NOAA-EMC#2881)
  Disable native grid writes for non-JEDI experiments; update C384 compression options (NOAA-EMC#2914)
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 16, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'emc/develop' into fix/c768_hera
ec0803d 
* emc/develop:
  Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917)
  Cleanup job for GEFS (NOAA-EMC#2919)
  Build GDASApp and unset memory in Gaea-C5 xml files (NOAA-EMC#2912)
  add 1 deg ocean/ice info to parm/config/gfs/config.resources (NOAA-EMC#2922)
  Support gefs C48 on Azure (NOAA-EMC#2881)
  Disable native grid writes for non-JEDI experiments; update C384 compression options (NOAA-EMC#2914)
  Add new UPP links to .gitignore (NOAA-EMC#2904)
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this pull request Sep 17, 2024
@KateFriedman-NOAA
Merge remote-tracking branch 'origin/develop' into feature/experiment…
3357a0d 
…al_obs_path

* origin/develop:
  Update global atmos upp job to use COMIN/COMOUT (NOAA-EMC#2867)
  Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917)
  Cleanup job for GEFS (NOAA-EMC#2919)
  Build GDASApp and unset memory in Gaea-C5 xml files (NOAA-EMC#2912)
  add 1 deg ocean/ice info to parm/config/gfs/config.resources (NOAA-EMC#2922)
  Support gefs C48 on Azure (NOAA-EMC#2881)
  Disable native grid writes for non-JEDI experiments; update C384 compression options (NOAA-EMC#2914)
@weihuang-jedi weihuang-jedi deleted the azure-gefs-2 branch September 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support gefs C48 on Azure
3 participants
@weihuang-jedi @aerorahul @WalterKolczynski-NOAA