Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev/gdasapp with JCB policies and g-w develop #2702

Conversation

RussTreadon-NOAA
Copy link
Contributor

Description

This PR is a companion to PR #2700. This PR differs in that it merges into dev/gdasapp

Resolves #2699

Type of change

  • Maintenance (update gdas.cd hash)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Cycled test on Dogwood, Hera, & Hercules

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

danholdaway and others added 30 commits May 29, 2024 14:35
* upsteam/develop:
  Archiving cleanup (NOAA-EMC#2621)
  Switch to Rocky 9 built external packages on Hercules (NOAA-EMC#2608)
  Add the capability to use slurm reservation nodes (NOAA-EMC#2627)
  Update forecast job to use COMIN/COMOUT (NOAA-EMC#2622)
  Update to add 1-deg global wave grid (NOAA-EMC#2619)
  Add C384mx025_3DVarAOWCDA yamls (NOAA-EMC#2625)
  Script to keep Jenkins Agent persistent from cron (NOAA-EMC#2634)
* upsteam/develop:
  Update ufs-weather-model  (NOAA-EMC#2646)
  Update wmo parm files to fix WMO header (NOAA-EMC#2652)
  Add IAU to snow DA (and its test) (NOAA-EMC#2610)
danholdaway and others added 24 commits June 14, 2024 18:05
This PR moves JCB into GDASapp. The PR
also bumps up the hash of GDASapp to what is in `feature/move_jcb`,
which at time of writing is develop plus the absorption of JCB into
GDASapp.
Note that I also took the changes from
NOAA-EMC#2641 to follow the
testing @RussTreadon-NOAA has done.
Optimize the gfswavepostpnt, gfswavepostbndpntbll, and gfswavepostbndpnt jobs

This is done by
1) reducing the number of calls to `sed`, `awk`, `grep`, and `cat` by
- performing operations on all files at once instead of looping over
each file
    - removing piped `cat` calls (e.g. `cat <file> | sed 'something'`)
    - combining `sed` and `grep` calls when possible
    - adding logic to `awk` calls instead of handling that logic in bash
2) minimizing as much as possible the amount of data on disk that has to
be read in (e.g. limiting sed to read only the line numbers it needs)
---------

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
Turns on high-frequency (hourly) output in the extended products test to
exercise that aspect of the code. This test only runs on WCOSS.

Also adds the hooks to optionally turn on the metplus jobs, but that is
deferred as they are not currently working correctly.
NCO has requested that each COM variable specify whether it is an input
or an output. This completes that process for the global-workflow
archive task.

Refs NOAA-EMC#2451 
---------

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
This PR is a hotfix for an incorrectly named (e.g., non-existent) `COM/`
template.
Resolves NOAA-EMC#2696 
Refs NOAA-EMC#2451
…put files (NOAA-EMC#2688)

This PR addresses issue NOAA-EMC#1252. The following is accomplished:

- Prior to removing files, the existence of a file is checked prior to
attempting to remove; this is performed as noted
[here](NOAA-EMC#1252 (comment));
this PR only addresses the the `chgrp` issue.

Refs NOAA-EMC#1252

---------

Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
Eliminates the post groups used for upp and products jobs so that each
task only processes one forecast hour. This is more efficient and
greatly simplifies downstream dependencies that depend on a specific
forecast hour.

Resolves NOAA-EMC#2666
Refs NOAA-EMC#2642
@RussTreadon-NOAA
Copy link
Contributor Author

This PR is not needed given PR #2700. Close this PR to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.