Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CADS use flexibility #2540

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Add CADS use flexibility #2540

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b423e02
Changes to this script copy CADS fix files to the working directory a…
wx20jjung Apr 10, 2024
67647fc
Merge branch 'NOAA-EMC:develop' into CADS
wx20jjung Apr 10, 2024
e20d167
Merge branch 'NOAA-EMC:develop' into CADS
wx20jjung Apr 23, 2024
06c7b90
Merge branch 'NOAA-EMC:develop' into CADS
wx20jjung Apr 23, 2024
696dcf9
Changes to how the flags for the Cloud and Aerosol Detection Software…
wx20jjung Apr 23, 2024
f57e581
Fixed a typo and added some comments.
wx20jjung Apr 24, 2024
f45d382
Update scripts/exglobal_atmos_analysis.sh
wx20jjung Apr 25, 2024
bbc0bcf
Moved the *_CADS flags to the $OBSQC namelist secton as suggested by …
wx20jjung Apr 25, 2024
b47e580
Specifically set the AIRS_CADS, CRIS_CADS, and IASI_CADS to false in …
wx20jjung Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions parm/config/gfs/config.anal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,4 +150,10 @@ if [[ ${RUN_ENVIR} == "emc" ]]; then
# fi
fi

# Flag to turn on (.true.) or off (.false.) the infrared cloud and aerosol detection software
# for AIRS, CrIS, and IASI. Default is .false.
export AIRS_CADS=${AIRS_CADS:-".false."}
export CRIS_CADS=${CRIS_CADS:-".false."}
export IASI_CADS=${IASI_CADS:-".false."}

echo "END: config.anal"
8 changes: 7 additions & 1 deletion scripts/exglobal_atmos_analysis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,14 +678,20 @@ if [ ${DOHYBVAR} = "YES" ]; then
SETUP="niter(1)=50,niter(2)=150,niter_no_qc(1)=25,niter_no_qc(2)=0,thin4d=.true.,ens_nstarthr=3,l4densvar=${l4densvar},lwrite4danl=${lwrite4danl},${SETUP}"
JCOPTS="ljc4tlevs=.true.,${JCOPTS}"
STRONGOPTS="tlnmc_option=3,${STRONGOPTS}"
OBSQC="c_varqc=0.04,airs_cads=.false.,cris_cads=.false.,iasi_cads=.false.,${OBSQC}"
OBSQC="c_varqc=0.04,${OBSQC}"
fi
fi

if [ ${DONST} = "YES" ]; then
NST="nstinfo=${NSTINFO},fac_dtl=${FAC_DTL},fac_tsl=${FAC_TSL},zsea1=${ZSEA1},zsea2=${ZSEA2},${NST}"
fi

# Infrared cloud and aerosol detection software (CADS) on (.true.) - off (.false.) flags
export AIRS_CADS=${AIRS_CADS:-".false."}
export CRIS_CADS=${CRIS_CADS:-".false."}
export IASI_CADS=${IASI_CADS:-".false."}
OBSQC="airs_cads=${AIRS_CADS},cris_cads=${CRIS_CADS},iasi_cads=${IASI_CADS},${OBSQC}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the *_cads variables are not inside an if-block, this OBSQC line will be executed every time exglobal_atmos_analysis.sh is run.

Given this we could remove lines 689-690 and simply add airs_cads=${AIRS_CADS},cris_cads=${CRIS_CADS},iasi_cads=${IASI_CADS} to the OBSQC namelist on lines 751 to 756. For example,

&OBSQC
  dfact=0.75,dfact1=3.0,noiqc=.true.,oberrflg=.false.,c_varqc=0.02,
  use_poq7=.true.,qc_noirjaco3_pole=.true.,vqc=.false.,nvqc=.true.,
  aircraft_t_bc=.true.,biaspredt=1.0e5,upd_aircraft=.true.,cleanup_tail=.true.,
  tcp_width=70.0,tcp_ermax=7.35, airs_cads=${AIRS_CADS},
  cris_cads=${CRIS_CADS}, iasi_cads=${IASI_CADS},
  ${OBSQC}


##############################################################
# Create global_gsi namelist
cat > gsiparm.anl << EOF
Expand Down
Loading