-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messaging to resolve bugzilla #2468
Merged
KateFriedman-NOAA
merged 4 commits into
NOAA-EMC:develop
from
KateFriedman-NOAA:feature/bugzilla_1374
Apr 10, 2024
Merged
Improve error messaging to resolve bugzilla #2468
KateFriedman-NOAA
merged 4 commits into
NOAA-EMC:develop
from
KateFriedman-NOAA:feature/bugzilla_1374
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve bugzilla 1374. Refs NOAA-EMC#1253
WalterKolczynski-NOAA
approved these changes
Apr 8, 2024
aerorahul
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
@KateFriedman-NOAA |
91cd16b
to
3e17ddf
Compare
Have removed the last commit which merged another branch in. Will now complete this PR without that branch merged in. |
danholdaway
added a commit
to danholdaway/global-workflow
that referenced
this pull request
Apr 15, 2024
* upstream/develop: Update fbwind for COM refactor (NOAA-EMC#2479) Update parm files for atm product (NOAA-EMC#2486) Fix paths in prepocnobs task (NOAA-EMC#2459) Add oceanalecn to workflow generator (NOAA-EMC#2409) Add support for CADS IR cloud detection scheme in the GSI (NOAA-EMC#2478) Improve error messaging to resolve bugzilla (NOAA-EMC#2468) Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list (NOAA-EMC#2471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes care of bugzilla #1374. The error messaging for fatal errors is improved to add "FATAL" where missing and state the file that is missing (when not already mentioned). Correction of the error message mentioned in the bugzilla is included in this.
Resolves #1253
Type of change
Change characteristics
How has this been tested?
Visual inspection
Checklist