Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to JCB for aerosol DA jobs #3035

Closed
1 task
CoryMartin-NOAA opened this issue Oct 24, 2024 · 4 comments · Fixed by #3125
Closed
1 task

Switch to JCB for aerosol DA jobs #3035

CoryMartin-NOAA opened this issue Oct 24, 2024 · 4 comments · Fixed by #3125
Labels
feature New feature or request

Comments

@CoryMartin-NOAA
Copy link
Contributor

What new functionality do you need?

Use JCB to generate YAMLs for all the JEDI-based aerosol DA tasks

What are the requirements for the new functionality?

Use JCB to generate YAMLs for all the JEDI-based aerosol DA tasks

Acceptance Criteria

  • aerosol DA cycled CI tests pass

Suggest a solution (optional)

No response
@CoryMartin-NOAA CoryMartin-NOAA added feature New feature or request triage Issues that are triage labels Oct 24, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Nov 19, 2024
@CoryMartin-NOAA
Copy link
Contributor Author

The PR that resolves this issue will also include the switch to the Jedi class and an additional rescaling factor for the aerosol B matrix

@CoryMartin-NOAA CoryMartin-NOAA mentioned this issue Nov 26, 2024
Merged
14 tasks
@CoryMartin-NOAA
Copy link
Contributor Author

Work is progressing in CoryMartin-NOAA:feature/aero-jcb. This is nearing completion and a PR will be issued soon. We are mainly waiting for a science test from @andytangborn who will provide some updated fix files (and a fix file issue will be opened to copy those over) for the aerosol B matrix. Once that is complete, this branch will be tested, fix versions updated, and a PR issued.

@andytangborn
Copy link
Contributor

Work is progressing in CoryMartin-NOAA:feature/aero-jcb. This is nearing completion and a PR will be issued soon. We are mainly waiting for a science test from @andytangborn who will provide some updated fix files (and a fix file issue will be opened to copy those over) for the aerosol B matrix. Once that is complete, this branch will be tested, fix versions updated, and a PR issued.

I'm assuming that the rescale files are what you are referring to here, and that once we have a good candidate then they can be staged.

@CoryMartin-NOAA
Copy link
Contributor Author

@andytangborn yes

@CoryMartin-NOAA CoryMartin-NOAA mentioned this issue Dec 11, 2024
Closed
4 tasks
sbanihash pushed a commit to sbanihash/global-workflow that referenced this issue Dec 14, 2024
@CoryMartin-NOAA @RussTreadon-NOAA
@DavidNew-NOAA @sbanihash
Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125)
220bae8 
This PR switches to using JCB for aerosol DA YAML generation + makes use
of the Jedi class refactoring already done by @DavidNew-NOAA for the
atmospheric JEDI-based DA.

Resolves NOAA-EMC#3035

Note this PR is in draft for 2 reasons. 1) Need associated GDASApp PR to
be opened and merged first and 2) requires some fix file updates. This
will be coordinated with an issue and linked to this PR once
@andytangborn is satisfied with a first-attempt at the fix files.
---------

Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov>
Co-authored-by: DavidNew-NOAA <david.new@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch Aerosol DA to use JCB and Jedi class CoryMartin-NOAA/global-workflow
3 participants
@CoryMartin-NOAA @WalterKolczynski-NOAA @andytangborn