Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCO Bug] Clean up redundant or unused transfer files in parm/transfer/ #2516

Closed
KateFriedman-NOAA opened this issue Apr 22, 2024 · 1 comment · Fixed by #2517
Closed

[NCO Bug] Clean up redundant or unused transfer files in parm/transfer/ #2516

KateFriedman-NOAA opened this issue Apr 22, 2024 · 1 comment · Fixed by #2517
Assignees
@KateFriedman-NOAA
Labels
nco-bug Something isn't working in Ops.

Comments

@KateFriedman-NOAA
Copy link
Member

What is wrong?

The parm/transfer files are old and outdated. Update to current parm files used in ops.

From NCO bugzilla:

In the parm/transfer/ directory, there are many redundant files now coming from the WCOSS2 transition.
e.g. transfer_gfs_1.list matches transfer_gfs_gfs_1.list.
For the duplicates, the files used are the transfer_gfs_gfs_* transfer_gfs_gdas_*, and
transfer_gfs_enkfgdas_* files. 

The transfer_rdhpcs_* files need to be investigated further to determine which are needed now.

What should have happened?

Unused/unneeded transfer parm files should not exist.

Steps to reproduce

N/A

Bugzilla issue

1383

Additional information

This cleanup has already happened in the GFSv16 system (d466e83).

Do you have a proposed solution?

Repeat the cleanup that happened in the GFSv16 system into the develop branch. Replace develop parm/transfer/* files with what now exists in the dev/gfs.v16 branch.
@KateFriedman-NOAA KateFriedman-NOAA added the nco-bug Something isn't working in Ops. label Apr 22, 2024
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Apr 22, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Apr 22, 2024
@KateFriedman-NOAA
Remove outdated/unneeded parm transfer lists
f67281e 
Refs NOAA-EMC#2516
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Apr 22, 2024
@KateFriedman-NOAA
Add updated parm transfer lists from ops
61fe607 
Bring in the current transfer parm list files
from the operational GFSv16 system. These
were reviewed and approved by NCO.

Refs NOAA-EMC#2516
@KateFriedman-NOAA KateFriedman-NOAA mentioned this issue Apr 22, 2024
Merged
@KateFriedman-NOAA
Copy link
Member Author

CI testing is not required for this PR since these parm/transfer/*.list files are only used in operations by dataflow and never invoked by developers or during pre-implementation testing.

WalterKolczynski-NOAA pushed a commit that referenced this issue Apr 22, 2024
@KateFriedman-NOAA
Update parm/transfer list files to match vetted GFSv16 set (#2517)
1b6cef5 
This PR updates the `parm/transfer/*.list` files within `develop` to
match the vetted set within the GFSv16 `dev/gfs.v16` branch. This
completes [bugzilla
#1383](http://www2.spa.ncep.noaa.gov/bugzilla/show_bug.cgi?id=1383) and
duplicates cleanup already done in the `dev/gfs.v16` branch @
d466e83.

The sets now match - showing comparison between `dev/gfs.v16`
`parm/transfer` folder contents and PR branch set:
```
[Kate.Friedman@fe5 feature-bugzilla_1383]$ pwd
/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/feature-bugzilla_1383
[Kate.Friedman@fe5 feature-bugzilla_1383]$ diff -r ../dev-gfs.v16/parm/transfer/ parm/transfer/
[Kate.Friedman@fe5 feature-bugzilla_1383]$
```

Resolves #2516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KateFriedman-NOAA KateFriedman-NOAA

Labels
nco-bug Something isn't working in Ops.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update parm/transfer list files to match vetted GFSv16 set KateFriedman-NOAA/global-workflow
1 participant
@KateFriedman-NOAA