Perturbation/Increments for cold starts #832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the model can only read in an increment file if initializing with a restart file. This functionality is also used to read in ensemble perturbations, and should also work for a external initial condition. The solution is to move the call to read_da_inc outside the if external_ic/restart logic.
There should be no changes to any regression tests.
Issue(s) addressed
Testing
How were these changes tested?
I used a regression test sandbox to compare a non-pertrubed run (which passes the RT) with a new perturbed run, and the differences are what I expect.
What compilers / HPCs was it tested with?
gaea - intel
Are the changes covered by regression tests? No, for some reason there is no checking of the read_da_increment capability anymore.
Have the ufs-weather-model regression test been run? On what platform?
Not the full suite
-No
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs