CCPP framework update and metadata bug fixes #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-physics for code review and testing
This was referenced Aug 12, 2021
…ge_feature_capgen_into_main_20210812
…ge_feature_capgen_into_main_20210812
…mal re-merge from feature/capgen (all files in ccpp-framework are identical)
…ramework and ccpp-physics
|
@DusanJovic-NOAA @junwang-noaa ccpp-framework and ccpp-physics submodules are updated, hashes are correct. Ready to merge fv3atm. |
junwang-noaa
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the submodule pointers for ccpp-framework and ccpp-physics and fixes a few small bugs in the CCPP prebuild config (order of variable definition files, derived data type definitions must come first) and
GFS_typedefs.meta(remove duplicate variables).Testing
See ufs-community/ufs-weather-model#745.
Dependencies
NCAR/ccpp-framework#391
earth-system-radiation/rte-rrtmgp#133
NCAR/ccpp-physics#718
#367
ufs-community/ufs-weather-model#745