-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UFS-Aerosols in P7 configurations #362
Merged
DusanJovic-NOAA
merged 35 commits into
NOAA-EMC:develop
from
rmontuoro:feature/enable-gocart-in-p7
Aug 13, 2021
Merged
Enable UFS-Aerosols in P7 configurations #362
DusanJovic-NOAA
merged 35 commits into
NOAA-EMC:develop
from
rmontuoro:feature/enable-gocart-in-p7
Aug 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
large scale rain, and convective rain at the end of each coupling step if coupling with chemistry model.
defining zero and one.
in noah/osu land-surface model subdriver.
band layer cloud optical depths (0.55 and 10 mu channels) to prevent floating invalid errors due to uninitialized optical depth arrays.
coupling array at the beginning of each coupling step if coupled with chemistry model.
the NUOPC Realize phase since it breaks coupling with aerosol component.
This reverts commit 735eb9e.
Update metadata description of GFS_interstitial_type for consistency with ccpp/physics.
13 tasks
Closed
climbfuji
approved these changes
Aug 12, 2021
@rmontuoro I merged the ccpp-physics PR, new hash is 55e0814. Please update the submodule pointer and revert the change in |
DusanJovic-NOAA
approved these changes
Aug 13, 2021
@DusanJovic-NOAA - done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes to support fully-coupled UFS configurations (P7) that include prognostic aerosols (UFS-Aerosols). The changes are needed to perform evaluation runs of UFS-Aerosols with prototype 7.1.
These changes may be revisited in the future, once a more general and comprehensive coupling interface has been implemented. Ideally, this interface will be able to populate internal and coupling buffers only for the component involved in the data exchange at a given time, avoiding unnecessary data copies and potentially improving model performance. The NUOPC Layer may need to be extended to provide up-to-date field connectivity information for each data exchange operation.
Note: This PR includes PR #357.
Issue(s) addressed
Testing
The changes were tested on Hera/Intel using both a fully-coupled (S2SW) and the FV3-GOCART (ATMAERO) UFS model configurations.
A new P7-based regression test including prognostic aerosols may be added if needed.
These updates do not affect the regression test baseline.
Dependencies
None