Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORK IN PROGRESS: fv3atm changes for splitting physics group in SDF #276

Closed

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 9, 2021

Heads-up

Note. Includes all the changes from #261 and #271, because this PR it will be merged afterwards and not having those PRs included in the development phase will lead to merge conflicts.

The commit history and changes will be much smaller once #261 and #271 are merged. The first PR that really belongs to this PR is 861a8c5.

Description

This PR contains the following changes:

  • Introduce GFS_suite_interstitial DDT that contains "persistent interstitial" variables (allocated for each block)
  • Add the necessary logic in ccpp/driver/CCPP_driver.F90 and atmos_model.F90 to call the surface_physics and atmosphere_physics groups instead of the physics group, currently hardcoded for the FV3_GFS_v16 suite
  • Note. further optimization is required to move as many as possible of the suite interstitial DDT components back to the original interstitial DDT to reduce memory footprint

Issue(s) addressed

n/a

Testing

See ufs-community/ufs-weather-model#516

Dependencies

NCAR/ccpp-physics#615
#276
ufs-community/ufs-weather-model#516

…pt RRTMGP interstititals over from GFS_interstitial DDT
…osphere_physics, make corresponding adjustments in ccpp/driver/CCPP_driver.F90 and atmos_model.F90
@climbfuji
Copy link
Collaborator Author

Progress has stalled, and the code capabilities doen't seem to be required right now. Closing.

@climbfuji climbfuji closed this Aug 5, 2021
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Sep 29, 2023
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this pull request Nov 17, 2023
…ength-mismatch

initialize two arrays and fix fortran coding error plus PRs NOAA-EMC#285 and NOAA-EMC#276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant