-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORK IN PROGRESS: fv3atm changes for splitting physics group in SDF #276
Closed
climbfuji
wants to merge
15
commits into
NOAA-EMC:develop
from
climbfuji:split_physics_group_20210409
Closed
WORK IN PROGRESS: fv3atm changes for splitting physics group in SDF #276
climbfuji
wants to merge
15
commits into
NOAA-EMC:develop
from
climbfuji:split_physics_group_20210409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove_zorl_interstitial
…ove_zorl_interstitial
…ove_zorl_interstitial
…ace composites from ocean to water
…ji/fv3atm into rename_surface_composites_ocean_water
…pt RRTMGP interstititals over from GFS_interstitial DDT
…osphere_physics, make corresponding adjustments in ccpp/driver/CCPP_driver.F90 and atmos_model.F90
This was referenced Apr 12, 2021
Progress has stalled, and the code capabilities doen't seem to be required right now. Closing. |
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Sep 29, 2023
LarissaReames-NOAA
pushed a commit
to LarissaReames-NOAA/fv3atm
that referenced
this pull request
Nov 17, 2023
…ength-mismatch initialize two arrays and fix fortran coding error plus PRs NOAA-EMC#285 and NOAA-EMC#276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heads-up
Note. Includes all the changes from #261 and #271, because this PR it will be merged afterwards and not having those PRs included in the development phase will lead to merge conflicts.
The commit history and changes will be much smaller once #261 and #271 are merged. The first PR that really belongs to this PR is 861a8c5.
Description
This PR contains the following changes:
GFS_suite_interstitial
DDT that contains "persistent interstitial" variables (allocated for each block)ccpp/driver/CCPP_driver.F90
andatmos_model.F90
to call thesurface_physics
andatmosphere_physics
groups instead of thephysics
group, currently hardcoded for theFV3_GFS_v16
suiteIssue(s) addressed
n/a
Testing
See ufs-community/ufs-weather-model#516
Dependencies
NCAR/ccpp-physics#615
#276
ufs-community/ufs-weather-model#516