Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bigfix to variable INTENT #491

Closed

Conversation

ukmo-ccbunney
Copy link
Collaborator

@ukmo-ccbunney ukmo-ccbunney commented Oct 7, 2021

Pull Request Summary [SEE #499]

Fixes issue where some compilers generate an error relating to the INTENT of an subroutine parameter in w3ounfmeta.ftn

Issue #489 describes.

Description

Some compilers (e.g. the Cray compiler at version 8.3.4) complain about the INTENT(IN) of the META parameter in the READ_META_PAIRS subroutine in w3oundmeta.ftn.

An easy fix is to make change the intent to INTENT(INOUT).

Issue(s) addressed

Commit Message

  • Small bugfix to INTENT of subroutine parameter in w3ounfmeta.

Testing

  • How were these changes tested? Regtests
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
  • If a new feature was added, was a new regression test added? N/A
  • Have regression tests been run? Yes
  • Which compiler / HPC you used to run the regression tests in the PR? Cray/GNU/Intel compiler. Cray HPC

No differences in regression tests other than known non-B4B regtest mww3_test_03:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (11 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (7 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (11 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)

matrixDiff_issue489.zip

@ukmo-ccbunney ukmo-ccbunney added the bug Something isn't working label Oct 7, 2021
@ukmo-ccbunney
Copy link
Collaborator Author

This PR will be merged via the UKMO Staging Branch; see #499

@ukmo-ccbunney ukmo-ccbunney deleted the bugfix/issue489-intent branch April 28, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[w3ounfmeta] INTENT mismatch
1 participant