Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial clean-up in preparation for merging to global-workflow #20

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Mar 19, 2024

This PR:

  • adds a README.md to describe the project and basic instructions on how to build the executables of this repository
  • removes the individual makefile for each executable
  • removes older modulefiles
  • uses spack-stack installed modules on hera and orion (hercules will be added later)
  • changes permissions on the source code to remove -x
  • updates detect_machine.sh to allow building on compute nodes

The build was successful on Hera, Orion, and WCOSS2

To build:

git clone -b feature/prep_for_gfsv17 https://github.com/noaa-emc/emc_gfs_wafs
cd emc_gfs_wafs
./ush/build.sh

The executables will be built under install/bin

tree install/
install/
└── bin
    ├── wafs_blending_0p25.x
    ├── wafs_cnvgrib2.x
    ├── wafs_gcip.x
    ├── wafs_grib2_0p25.x
    └── wafs_makewafs.x

@aerorahul aerorahul requested a review from YaliMao-NOAA March 19, 2024 02:26
@YaliMao-NOAA
Copy link
Collaborator

Thank you @aerorahul
May I know whether it's a global-workflow standard that the executable files have to be under install/bin? It used be under exec.

@aerorahul
Copy link
Contributor Author

aerorahul commented Mar 19, 2024

Thank you @aerorahul May I know whether it's a global-workflow standard that the executable files have to be under install/bin? It used be under exec.

They will be linked under exec/ at the application level (in the GFS) to conform w/ EE2 standards.
At build and compile time, all component build artifacts are installed under a local install/

@YaliMao-NOAA YaliMao-NOAA merged commit 1ae71a1 into develop Mar 19, 2024
@aerorahul aerorahul deleted the feature/prep_for_gfsv17 branch March 19, 2024 15:40
@YaliMao-NOAA
Copy link
Collaborator

I compiled WAFS packages using CMake, reran the same case and the outputs are bit-wise identical other than GCIP which depends on accumulative METAR/SHIP/LIGHTNING observation bufr data.

@aerorahul
Copy link
Contributor Author

I compiled WAFS packages using CMake, reran the same case and the outputs are bit-wise identical other than GCIP which depends on accumulative METAR/SHIP/LIGHTNING observation bufr data.

Thanks for the confirmation @YaliMao-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants