Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRFS–MPAS: Add the U. Utah SLR field ("SDEN") #1130

Closed
wants to merge 2 commits into from

Conversation

jaymes-kenyon
Copy link
Contributor

@jaymes-kenyon jaymes-kenyon commented Feb 3, 2025

This PR addresses issue #1125.

Specifically, it adds the University of Utah snow-to-liquid ratio (SLR) diagnostic output to RRFS–MPAS applications, yielding a GRIB2 field abbreviated "SDEN". Recent development with this diagnostic occurred in the merged PR #1104; refer to that PR for more details.

Additionally, the current PR fixes an unrelated typo in code comments.

@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 3, 2025 that may be closed by this pull request
@JesseMeng-NOAA
Copy link
Contributor

This PR addresses issue #1125.

Specifically, it adds the University of Utah snow-to-liquid ratio (SLR) diagnostic output to RRFS–MPAS applications, yielding a GRIB2 field abbreviated "SDEN". Recent development with this diagnostic occurred in the merged PR #1104; refer to that PR for more details.

For the "SDEN" field, note that the current PR specifies <scale>3.0</scale>, rather than the default setting of 6.0.

Additionally, the current PR fixes an unrelated typo in code comments.

Please modify <scale>3.0</scale> to 6.0. Thanks.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Feb 3, 2025
@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon @JesseMeng-NOAA Could you take a look at my UPP standalone test for MPAS at /home/Wen.Meng/stmp2/mpas_2024112100-after on Hera?
It appears to me the SLR field "SDEN" was successfully generated as:

 wgrib2 WRFTWO12.tm00 -match SDEN -s -stats
40:36132094:d=2024112012:SDEN:surface:12 hour fcst::ndata=1905141:undef=1459740:mean=88.4948:min=45.653:max=679.477:cos_wt_mean=89.7173

Please let me know if you see issues.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2 without baseline changes.

@jaymes-kenyon
Copy link
Contributor Author

jaymes-kenyon commented Feb 3, 2025

@JesseMeng-NOAA @WenMeng-NOAA — I added a third commit to address Jesse's request, bit the commit seems to be hanging in GitHub. The upper-right corner of this page still says "processing updates". Hopefully this PR will show the new commit soon.

@jaymes-kenyon jaymes-kenyon marked this pull request as draft February 3, 2025 19:25
@WenMeng-NOAA WenMeng-NOAA marked this pull request as ready for review February 3, 2025 23:22
@WenMeng-NOAA
Copy link
Collaborator

@JesseMeng-NOAA @WenMeng-NOAA — I added a third commit to address Jesse's request, bit the commit seems to be hanging in GitHub. The upper-right corner of this page still says "processing updates". Hopefully this PR will show the new commit soon.

@jaymes-kenyon It looks like the 'processing update' status is stuck. Could you try opening a new PR?

@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA — Due to GitHub issues, this PR (now closed) was replaced by PR #1132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPAS No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants